From owner-freebsd-current@FreeBSD.ORG Fri Sep 10 12:00:21 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A5F0D10656DE; Fri, 10 Sep 2010 12:00:21 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 74C0B8FC15; Fri, 10 Sep 2010 12:00:21 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 18A3D46B9D; Fri, 10 Sep 2010 08:00:21 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id F3BD88A03C; Fri, 10 Sep 2010 08:00:09 -0400 (EDT) From: John Baldwin To: freebsd-current@freebsd.org Date: Fri, 10 Sep 2010 07:47:39 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <20100909191750.GA58228@freebsd.org> <20100909194109.GA64914@freebsd.org> <20100909195045.GA68352@freebsd.org> In-Reply-To: <20100909195045.GA68352@freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201009100747.39964.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Fri, 10 Sep 2010 08:00:10 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Alexander Best Subject: Re: {arch}/conf/DEFAULTS and uart X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Sep 2010 12:00:21 -0000 On Thursday, September 09, 2010 3:50:45 pm Alexander Best wrote: > On Thu Sep 9 10, Alexander Best wrote: > > On Thu Sep 9 10, Alexander Best wrote: > > > hi there, > > > > > > except for arm most archs seem to enforce uart support in conf/DEFAULTS. is > > > this really necessary? shouldn't DEFAULTS only contain vital devices/options > > > without a kernel on a specific arch won't function at all? > > > > jhb just explained to me, that the uart entry in DEFAULTS is not a controller > > or something like that, but the uart backend to use *if* uart gets defined in > > the kernel config. > > > > sorry for the noise folks. > > however i found some missing comments and incorrect syntax which i fixed. > > see the attached patch. I think the ia64 ordering for 'io and mem' is probably more correct (alphabetically sorted), so I would fix i386 and amd64 and leave ia64 alone. The powerpc 'machine' changes are wrong I think as it would break GENERIC64 and powerpc64 kernel configs in general. Nathan purposefully removed 'machine' from the powerpc DEFAULTS. -- John Baldwin