From owner-svn-src-all@FreeBSD.ORG Sun Jun 16 09:42:22 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 81D6C416; Sun, 16 Jun 2013 09:42:22 +0000 (UTC) (envelope-from edschouten@gmail.com) Received: from mail-ve0-x229.google.com (mail-ve0-x229.google.com [IPv6:2607:f8b0:400c:c01::229]) by mx1.freebsd.org (Postfix) with ESMTP id 0FB611175; Sun, 16 Jun 2013 09:42:21 +0000 (UTC) Received: by mail-ve0-f169.google.com with SMTP id m1so1454524ves.28 for ; Sun, 16 Jun 2013 02:42:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=OFoR0RFHuKdbG4UVUXOLaoiYzB/i/eduKD5LOx5CUUU=; b=PD2gVaMOhqsQJW0kADYKTQVOSsOB8yQGeSrDPCkccBUw+kQLAL+12oRowIWxCwLxx8 85zIHfTB4RX0SNocGqVKPCRLWJ74iSTz4ZkK6cjY32Ue3YmlY8lgwr3SND/7Fb8XBods E/5avjRqr7z49k2UJdI23Z6x19tzHPwM8kohs2mrHaHB5ovOE8MPNq6VztzQlQQZjqEY tYQRxYI2NOUrrFaKxzaw1TNtPMdU3fT7zfyNo8pA1yy98APnTmR8+/F8MimTshHegTSz Ze+0t3JBWsb+DLJ3t30wYEK9K9jwFzjefZQQHw4H4wh/EBilyPOshDBJ4AB+8qFgdFzg MbPg== MIME-Version: 1.0 X-Received: by 10.59.0.2 with SMTP id au2mr2101165ved.83.1371375741581; Sun, 16 Jun 2013 02:42:21 -0700 (PDT) Sender: edschouten@gmail.com Received: by 10.220.107.139 with HTTP; Sun, 16 Jun 2013 02:42:21 -0700 (PDT) In-Reply-To: <20130615232314.GB1403@garage.freebsd.pl> References: <201306152218.r5FMI0uT047135@svn.freebsd.org> <20130615232314.GB1403@garage.freebsd.pl> Date: Sun, 16 Jun 2013 11:42:21 +0200 X-Google-Sender-Auth: poax0zvSKecOZO7puWAGT169MrA Message-ID: Subject: Re: svn commit: r251796 - head/sbin/hastd From: Ed Schouten To: Pawel Jakub Dawidek Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jun 2013 09:42:22 -0000 Hello Pawel, 2013/6/16 Pawel Jakub Dawidek : > Hmm, I don't like HAST to be a victim of bad LLVM import. This is not > the kind of software you run on HEAD (so it might go unnoticed > initially) and this is the kind of software that when breaks can have > serious consequences. > > What kind of breaks are we talking about? That HAST will stop compiling > or HAST can start corrupting data? My intent is that we shouldn't see a whole lot of C11 atomics in FreeBSD appear before we have at least one stable branch that supports it properly (10.0). The problem with this approach is that I've noticed that if we import things into our base system that we hardly use, it will get almost no coverage. This causes all sorts of breakage that could have prevented easily. Good examples: http://svnweb.freebsd.org/base/head/sys/sys/stdatomic.h?r1=251347&r2=251566 http://svnweb.freebsd.org/base/head/sys/sys/stdatomic.h?r1=250883&r2=251192 http://svnweb.freebsd.org/base/head/sys/sys/stdatomic.h?r1=228862&r2=228880 By at least letting a couple of pieces of code use C11, this is less likely to regress again. The examples that I gave of course refer to breakage of , not regressions in LLVM itself. I merely named regressions in LLVM as a worst-case example. My assumption would be that any breakage in LLVM related to C11 atomics is as likely as any other kind of regression. If you want, I can revert this change. Still, I would actually prefer it if we not only let HAST use C11 atomics, but also a small number of other pieces of code. That way any kind of breakage would become pretty visible. Thoughts? -- Ed Schouten