From owner-freebsd-current@freebsd.org Sun May 20 03:50:37 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 47B39EF1375 for ; Sun, 20 May 2018 03:50:37 +0000 (UTC) (envelope-from marklmi26-fbsd@yahoo.com) Received: from sonic306-21.consmr.mail.gq1.yahoo.com (sonic306-21.consmr.mail.gq1.yahoo.com [98.137.68.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C8D116D16D for ; Sun, 20 May 2018 03:50:36 +0000 (UTC) (envelope-from marklmi26-fbsd@yahoo.com) X-YMail-OSG: JakAo6IVM1l0jgd3HdA6bg9VuLBY..cb4NQ6IcLB5l0QFXlLNjVvUMAezfTPEyW HXIzPPmL97AWloEuNCcuaZLh4sbaegziYdsXJYczUqj0NGW.qR.UuN.ugyHJG5jw4twJQOgrOzav h8mnj_isFbsIVmI89cKSM4puL4ZRMaAhNrkh1IyzAjdKZWP8OMBPy25BvlgG6VXbtx7nbQWcJWt8 FoBwuv_N7a1fIG5_5chv3vBwG8A6j2Tv8i8KqeOXBSeDa_q5TTYpPsjdTvHHPlARL4a_98x4Bhr7 B9tOO3G3rPYkejBLeiGjLf5iO6Ym9HJ3vKFBewekLJ0dSJD3iEkut6wAl24CPm_c4eR9WPOnSZYU hQ1Qwpc5WWmLzT9BNSzcoJhfF9jQ4JipAPKfkbNJgxqJkBfL45YBVLSETfWqHFiJ2loBNOJrLAVW Ffl9KoD3uJF2KUmdqFSMpOiqsUsULwBpSlRl.BBdjepDccLdRvM_Put3EBHou6IQdFpZgi5.tn9d 8kg9uVHAm7E.D95RVi55VG0fgkojZSoHkEUd_lgpp7C68Vnb5S7JUbPqxUI.5GjEjTVxxQbyIZ5. pbu4P5wAYT7LFaYydxJCA_dQgHbdWzd__017TGVgaf.QIDFg90WuBUqmdM9c2PDyGZPT307Ylq1H .Zw-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.gq1.yahoo.com with HTTP; Sun, 20 May 2018 03:50:34 +0000 Received: from c-76-115-7-162.hsd1.or.comcast.net (EHLO [192.168.1.25]) ([76.115.7.162]) by smtp417.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID c43db7733ab226b5970c5675e64ccd25; Sun, 20 May 2018 03:50:34 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\)) Subject: Re: head -r333905 broke the builds [ -r333906 changed the details but they are still broken] Date: Sat, 19 May 2018 20:50:33 -0700 References: <1E5B6B0B-82B2-45F2-B10D-B5227C8BDFBC@yahoo.com> To: mmacy@FreeBSD.org, FreeBSD Current In-Reply-To: <1E5B6B0B-82B2-45F2-B10D-B5227C8BDFBC@yahoo.com> Message-Id: <31730734-59C9-44C1-9B2B-27DEA5BE867E@yahoo.com> X-Mailer: Apple Mail (2.3445.6.18) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 May 2018 03:50:37 -0000 On 2018-May-19, at 7:56 PM, Mark Millard = wrote: > https://ci.freebsd.org shows all the builds being broken and > going through the list -r333903 was working but -r333905 and > later are not. (I ignore riscv64 here.) >=20 > Using powerpc64 as an -r333905 example: >=20 > --- sourcefilter.o --- > In file included from = /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/netinet/ip_var.h:39, > from /usr/src/lib/libc/net/sourcefilter.c:43: > /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:42: = error: expected declaration specifiers or '...' before 'epoch_cb_count' > cc1: warnings being treated as errors > /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:42: = warning: data definition has no type or storage class > /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:43: = error: expected declaration specifiers or '...' before 'epoch_cb_task' > /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:43: = warning: 'struct grouptask' declared inside parameter list > /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:43: = warning: its scope is only this definition or declaration, which is = probably not what you want > /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:43: = warning: data definition has no type or storage class > /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:43: = error: conflicting types for 'DPCPU_DECLARE' > /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:42: = error: previous declaration of 'DPCPU_DECLARE' was here > /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h: In = function 'epoch_enter_preempt': > /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:68: = error: 'curthread' undeclared (first use in this function) > /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:68: = error: (Each undeclared identifier is reported only once > /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:68: = error: for each function it appears in.) > /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h: In = function 'epoch_exit_preempt': > /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:81: = error: 'curthread' undeclared (first use in this function) >=20 >=20 > This seems to match up with: >=20 > Author: mmacy > Date: Sun May 20 00:22:28 2018 > New Revision: 333905 > URL:=20 > https://svnweb.freebsd.org/changeset/base/333905 >=20 >=20 > Log: > ip(6)_freemoptions: defer imo destruction to epoch callback task >=20 > Avoid the ugly unlock / lock of the inpcbinfo where we need to > figure out what kind of lock we hold by simply deferring the > operation to another context. (Also a small dependency for > converting the pcbinfo read lock to epoch) >=20 > Modified: > head/sys/netinet/in_mcast.c > head/sys/netinet/in_pcb.c > head/sys/netinet/ip_var.h > head/sys/netinet6/in6_mcast.c > head/sys/netinet6/in6_var.h > head/sys/netinet6/ip6_var.h It looks like -r333906 changed the error details. Using i386 from ci.freebsd.org this time: --- all_subdir_usr.sbin/sendmail --- In file included from /usr/src/contrib/sendmail/src/daemon.c:51: In file included from = /usr/obj/usr/src/i386.i386/tmp/usr/include/netinet/ip_var.h:39: In file included from = /usr/obj/usr/src/i386.i386/tmp/usr/include/sys/epoch.h:33: In file included from = /usr/obj/usr/src/i386.i386/tmp/usr/include/sys/proc.h:47: In file included from = /usr/obj/usr/src/i386.i386/tmp/usr/include/sys/filedesc.h:42: /usr/obj/usr/src/i386.i386/tmp/usr/include/sys/priority.h:128:8: error: = redefinition of 'priority' struct priority { ^ /usr/src/contrib/sendmail/src/sendmail.h:1081:8: note: previous = definition is here struct priority ^ This seems to happen for -r333906 and later versions on all targets, including amd64. (I'm ignoring riscv64 that has been broken for a long time.) powerpc64 agrees despite the gcc 4.2.1: --- all_subdir_usr.sbin/sendmail --- In file included from = /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/filedesc.h:42, from = /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/proc.h:47, from = /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:33, from = /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/netinet/ip_var.h:39, from /usr/src/contrib/sendmail/src/daemon.c:51: /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/priority.h:128: = error: redefinition of 'struct priority' =3D=3D=3D Mark Millard marklmi26-fbsd at yahoo.com ( dsl-only.net went away in early 2018-Mar)