From owner-cvs-all@FreeBSD.ORG Sun Jul 31 08:34:32 2011 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AC0DB1065670; Sun, 31 Jul 2011 08:34:32 +0000 (UTC) (envelope-from support@rtmpd.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 686D98FC08; Sun, 31 Jul 2011 08:34:31 +0000 (UTC) Received: by fxe4 with SMTP id 4so4962655fxe.13 for ; Sun, 31 Jul 2011 01:34:30 -0700 (PDT) Received: by 10.223.21.141 with SMTP id j13mr4487193fab.79.1312101269790; Sun, 31 Jul 2011 01:34:29 -0700 (PDT) Received: from [10.0.1.2] ([79.115.160.60]) by mx.google.com with ESMTPS id n27sm2138371faa.28.2011.07.31.01.34.29 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 31 Jul 2011 01:34:29 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v1244.3) Content-Type: multipart/signed; boundary="Apple-Mail=_8E6DB316-2D5A-495C-B261-DB2DC3D4441D"; protocol="application/pkcs7-signature"; micalg=sha1 From: C++ RTMP Server Support In-Reply-To: <4E3510F7.2000405@FreeBSD.org> Date: Sun, 31 Jul 2011 11:34:28 +0300 Message-Id: <7C192122-697C-49BB-AADB-446C24962000@rtmpd.com> References: <201107301549.p6UFn7rK070976@repoman.freebsd.org> <4E3495B0.3070405@FreeBSD.org> <4E35108D.1040907@FreeBSD.org> <4E3510F7.2000405@FreeBSD.org> To: Doug Barton X-Mailer: Apple Mail (2.1244.3) X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Jin-Sih Lin , cvs-ports@FreeBSD.org, Li-Wen Hsu , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/crtmpserver Makefile distinfo pkg-plist ports/net/crtmpserver/files crtmpserver.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2011 08:34:32 -0000 --Apple-Mail=_8E6DB316-2D5A-495C-B261-DB2DC3D4441D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=iso-8859-1 Oh, I see the difference now. You basically use another construct to = gather the (default) values. IMHO, my solution is much much clear = because all variables which are read from rc.conf are in one single = place and for beginners like me the script is easier to read. Besides, you remove one variable (crtmpserver_config) and you put it's = default value inside the required_files variable, but you add another = one called pidfile. Again, IMHO, my version is easier to read. It might be an overkill as = you suggested, but I think that is a small price to pay and have the = script is clear for newbies. Seeing all the rc.conf vars in one place is = better than hunting them by eyeballing the file with care. In any case, whatever you decide is good for me and it will be the = template for the next revision. Thank you for your time On Jul 31, 2011, at 11:23 AM, Doug Barton wrote: > On 07/31/2011 01:21, Doug Barton wrote: >> +PORTVERSION=3D 1 >=20 > Should be PORTREVISION, sorry. >=20 >=20 > --=20 >=20 > Nothin' ever doesn't change, but nothin' changes much. > -- OK Go >=20 > Breadth of IT experience, and depth of knowledge in the DNS. > Yours for the right price. :) http://SupersetSolutions.com/ >=20 ------ C++ RTMP Server Support Email: support@rtmpd.com Web: http://www.rtmpd.com --Apple-Mail=_8E6DB316-2D5A-495C-B261-DB2DC3D4441D--