From owner-cvs-src@FreeBSD.ORG  Wed Jan 30 21:36:04 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CAD9816A417;
	Wed, 30 Jan 2008 21:36:04 +0000 (UTC) (envelope-from sam@errno.com)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id A5A5C13C467;
	Wed, 30 Jan 2008 21:36:04 +0000 (UTC) (envelope-from sam@errno.com)
Received: from trouble.errno.com (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id m0ULa4NA082540
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Wed, 30 Jan 2008 13:36:04 -0800 (PST) (envelope-from sam@errno.com)
Message-ID: <47A0EDC4.3040301@errno.com>
Date: Wed, 30 Jan 2008 13:36:04 -0800
From: Sam Leffler <sam@errno.com>
User-Agent: Thunderbird 2.0.0.9 (X11/20071125)
MIME-Version: 1.0
To: Alexander Motin <mav@FreeBSD.org>
References: <200801302124.m0ULOANe012024@repoman.freebsd.org>
In-Reply-To: <200801302124.m0ULOANe012024@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-DCC--Metrics: ebb.errno.com; whitelist
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/sys proc.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Jan 2008 21:36:04 -0000

Alexander Motin wrote:
> mav         2008-01-30 21:24:10 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/sys              proc.h 
>   Log:
>   Implement GET_STACK_USAGE() macro to get the current kernel thread stack usage.
>   This implemntation made for growing down stack organization like i386/amd64
>   platforms have, but prefers different machine dependent version if it is present.
>   

I think it is a mistake to fallback to a MD implementation; your MI 
implementation is broken on architectures that do not use the model you 
used so you any user of this will silently fail on such architectures.  
I suggest you need to fix this before you use this macro in any MI code.

    Sam