From owner-freebsd-sparc64@FreeBSD.ORG Tue May 11 15:23:15 2004 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1ABBC16A4CE for ; Tue, 11 May 2004 15:23:15 -0700 (PDT) Received: from mail.gmx.net (pop.gmx.de [213.165.64.20]) by mx1.FreeBSD.org (Postfix) with SMTP id C11F043D45 for ; Tue, 11 May 2004 15:23:13 -0700 (PDT) (envelope-from tmoestl@gmx.net) Received: (qmail 32118 invoked by uid 65534); 11 May 2004 22:23:12 -0000 Received: from p50907CE6.dip.t-dialin.net (EHLO timesink.dyndns.org) (80.144.124.230) by mail.gmx.net (mp004) with SMTP; 12 May 2004 00:23:12 +0200 X-Authenticated: #5374206 Received: by abel (Postfix, from userid 1001) id 6E64F6AD; Wed, 12 May 2004 00:23:12 +0200 (CEST) Date: Wed, 12 May 2004 00:23:11 +0200 From: Thomas Moestl To: Tijl Coosemans Message-ID: <20040511222311.GA728@timesink.dyndns.org> References: <20040511010823.GB72214@xor.obsecurity.org> <20040511213757.37a2189e.tijl@ulyssis.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040511213757.37a2189e.tijl@ulyssis.org> User-Agent: Mutt/1.5.6i cc: sparc64@freebsd.org Subject: Re: [ports-sparc64@bento.FreeBSD.org: libticables-3.7.7_2 failed on sparc64 5] X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 May 2004 22:23:15 -0000 On Tue, 2004/05/11 at 21:37:57 +0200, Tijl Coosemans wrote: > On Mon, 10 May 2004 18:08:23 -0700, Kris Kennaway wrote: > > > ----- Forwarded message from User Ports-sparc64 > > ----- > > Full build log at > http://bento.freebsd.org/errorlogs/sparc64-5-latest/libticables-3.7.7_2.log > > > In file included from ioports.c:45: > > /usr/include/machine/sysarch.h:53: error: syntax error before > > "utrap_entry_t" > > /usr/include/machine/sysarch.h:64: error: syntax error before "type" > > gmake[2]: *** [ioports.lo] Error 1 > > gmake[2]: Leaving directory > > `/tmp/a/ports/comms/libticables/work/libticables-3.7.7/src' > > gmake[1]: *** [all-recursive] Error 1 > > gmake[1]: Leaving directory > > `/tmp/a/ports/comms/libticables/work/libticables-3.7.7' > > gmake: *** [all] Error 2 > > *** Error code 2 > > Apparently src/sys/sparc64/include/sysarch.h uses > utrap_entry_t and utrap_handler_t without defining them. They are > however defined in src/sys/sparc64/utrap.h. > > So I'm wondering, should I file a PR for my port to include > machine/utrap.h(?) before machine/sysarch.h in case > of a sparc64 build (or get rid of it since it is only used on i386), > or is this a bug and should src/sys/sparc64/include/sysarch.h include > machine/utrap.h (probably wrapped inside an #ifndef _KERNEL)? Since machine/sysarch.h is by definition architecture dependent, it would probably be best to include it only when it is needed (i.e. in the i386 case). Adding an ucontext.h include might be worth considering, but then there seem to already be slightly different prerequisites on other platforms. - Thomas -- Thomas Moestl http://www.tu-bs.de/~y0015675/ http://people.FreeBSD.org/~tmm/ "I realized that the purpose of writing is to inflate weak ideas, obscure poor reasoning, and inhibit clarity." -- Calvin and Hobbes