From owner-svn-src-head@FreeBSD.ORG Tue Jan 20 07:51:33 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 009CF77A; Tue, 20 Jan 2015 07:51:32 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 64933380; Tue, 20 Jan 2015 07:51:32 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t0K7pR1u081002 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 20 Jan 2015 09:51:27 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t0K7pR1u081002 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id t0K7pQ2G081001; Tue, 20 Jan 2015 09:51:26 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 20 Jan 2015 09:51:26 +0200 From: Konstantin Belousov To: Hans Petter Selasky Subject: Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys Message-ID: <20150120075126.GA42409@kib.kiev.ua> References: <201501151532.t0FFWV2Y037455@svn.freebsd.org> <54BDD9E1.6090505@selasky.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54BDD9E1.6090505@selasky.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: "svn-src-head@freebsd.org" , Adrian Chadd , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2015 07:51:33 -0000 On Tue, Jan 20, 2015 at 05:30:25AM +0100, Hans Petter Selasky wrote: > On 01/19/15 22:59, Adrian Chadd wrote: > > Hi, > > > > Would you please check what the results of this are with CPU specific > > callwheels? > > > > I'm doing some 10+ gig traffic testing on -HEAD with RSS enabled (on > > ixgbe) and with this setup, the per-CPU TCP callwheel stuff is > > enabled. But all the callwheels are now back on clock(0) and so is the > > lock contention. :( > > > > Thanks, > > > > Hi, > > Like stated in the manual page, callout_reset_curcpu/on() does not work > with MPSAFE callouts any more! I.e. you 'fixed' some undeterminate bugs in callout migration by not doing migration at all anymore. > > You need to use callout_init_{mtx,rm,rw} and remove the custom locking > inside the callback in the TCP stack to get it working like before! No, you need to do this, if you think that whole callout KPI must be rototiled. It is up to the person who modifies the KPI, to ensure that existing code is not broken. As I understand, currently we are back to the one-cpu callouts. Do other people consider this situation acceptable ?