From nobody Tue Feb 25 11:48:20 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z2G84529Qz5pjgH; Tue, 25 Feb 2025 11:48:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z2G843JL9z3kJ8; Tue, 25 Feb 2025 11:48:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740484100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9o0wnGJOg6A0zBpS1GkIfnRYika9fje5gjQK5iru+SQ=; b=r2Y6dJ97kL+Wu3oZONac30lxGZ9tSW/rpaNnU/QQSgYbNCcj3DAbbV+caCXCqWZGTtp2jA 6lMxKZ1MmHmIRvtpPTr43Q80EGqGRjKDZ1bV8tgy/WGHu4N3Gz+mzhCAzwGMyLnFARC0Ey rYLSMlIrT9LYDwuWhcOF3XUDktl+eayx9UgdzPuyVWpW5oUyNpSTU4429IVsInq79wLhWX G0wKdu5b7oZaeGUZnaYJxG+t/TGLWbK8wh86N3SUv777mHwH/dC+Gc0qEYKrb18a5VBcMp eoc7U8JBxgNQArcX6D+D+YNBy6Orzv+c7EEJ4z7xaMDSz6mWKJgmrjOp9MMPWQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740484100; a=rsa-sha256; cv=none; b=L3NKA6Nhc0NlLXTJqy4ceWUYUQooqD/ixJR1+ujp45OAXaAJwVxQd8IMGOob4ZuUHmzgzK GREGSKt8ChCexJ2HaM6fqLZXKp4IrAppNN7NZVeXFEaDruJgIPIWdVzqmjggIQSfc+UW15 1R8ZFvoaD9R5/5YugnV1J4/5awtbfrWIhywvSQZHknbM131xtFSJZ3ShO5tPb7sU8hKQSc wdbbmnd8k4ZZgjHVw+kZrr2WC7SQG4FAveMj2W7xxVmjY7ECiHGxTCnVGHbjmqx6TAwr5G O1eoN43i3qrk0S2ZU/9FR8u+XYJEHVGyvIBjT6eQVnJ8ElriNBBijjCpFQumTQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740484100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9o0wnGJOg6A0zBpS1GkIfnRYika9fje5gjQK5iru+SQ=; b=B2zLKPR9xpXWRgbJhfK8wS19oNDQteblMLnOhwIfFKJyZNVpbvfMP7UCqJjuSmCR1DjIS/ a0+GqlFXAR9Kbsv/UA9aW6YFcZa7fIWpSwVp7aSoCsNH/iIFx+q0kJ9Qx+mhlJefMjabts QAIrSE6yF2G2knudkRkbUzFw1GSh+YzmGzsU4nGt6I2zFpyxvMihtuH+74lRkg4mwL7prC LtJ7QVI1w7DdQxug5bILCI2PT7jWBpcCMrhWt3lOzRndfmOuRsDzGk/mChxZgZ6oNFqb0i ubs1Z1kH/uCnhUHxV4mxEZcN89lenKZEwIRqOnfSVvV7K13VUzszqoLRbfS9EA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z2G842n4gz8pk; Tue, 25 Feb 2025 11:48:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 51PBmKOo051068; Tue, 25 Feb 2025 11:48:20 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 51PBmKTC051065; Tue, 25 Feb 2025 11:48:20 GMT (envelope-from git) Date: Tue, 25 Feb 2025 11:48:20 GMT Message-Id: <202502251148.51PBmKTC051065@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 40616b7e41ff - main - sound: Return if the new speed/format is the same as the current one List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 40616b7e41ff96b6d7522445b00f27f26d593a85 Auto-Submitted: auto-generated The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=40616b7e41ff96b6d7522445b00f27f26d593a85 commit 40616b7e41ff96b6d7522445b00f27f26d593a85 Author: Christos Margiolis AuthorDate: 2025-02-25 11:44:12 +0000 Commit: Christos Margiolis CommitDate: 2025-02-25 11:44:12 +0000 sound: Return if the new speed/format is the same as the current one This gives us a slight performance boost since we do not have to go through chn_setparam() and the driver functions. Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: dev_submerge.ch, emaste Differential Revision: https://reviews.freebsd.org/D48012 --- sys/dev/sound/pcm/channel.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sys/dev/sound/pcm/channel.c b/sys/dev/sound/pcm/channel.c index 19b2db321cee..c3ee50d51c4b 100644 --- a/sys/dev/sound/pcm/channel.c +++ b/sys/dev/sound/pcm/channel.c @@ -2110,6 +2110,9 @@ chn_setspeed(struct pcm_channel *c, uint32_t speed) oldformat = c->format; oldspeed = c->speed; + if (c->speed == speed) + return (0); + ret = chn_setparam(c, c->format, speed); if (ret != 0) { if (snd_verbose > 3) @@ -2138,6 +2141,9 @@ chn_setformat(struct pcm_channel *c, uint32_t format) oldformat = c->format; oldspeed = c->speed; + if (c->format == format) + return (0); + ret = chn_setparam(c, format, c->speed); if (ret != 0) { if (snd_verbose > 3)