From owner-freebsd-bugs@FreeBSD.ORG  Mon Jul 14 06:47:26 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 97B4F37B404; Mon, 14 Jul 2003 06:47:26 -0700 (PDT)
Received: from franky.speednet.com.au (franky.speednet.com.au [203.57.65.5])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 93DFB43FBF; Mon, 14 Jul 2003 06:46:30 -0700 (PDT)
	(envelope-from andyf@speednet.com.au)
Received: from hewey.af.speednet.com.au (hewey.af.speednet.com.au
	[203.38.96.242])h6EDkSDs046229;	Mon, 14 Jul 2003 23:46:28 +1000 (EST)
	(envelope-from andyf@speednet.com.au)
Received: from hewey.af.speednet.com.au (hewey.af.speednet.com.au
	[172.22.2.1])h6EDkR2b040871;	Mon, 14 Jul 2003 23:46:27 +1000 (EST)
	(envelope-from andyf@speednet.com.au)
Date: Mon, 14 Jul 2003 23:46:27 +1000 (EST)
From: Andy Farkas <andyf@speednet.com.au>
X-X-Sender: andyf@hewey.af.speednet.com.au
To: Kris Kennaway <kris@freebsd.org>
In-Reply-To: <200307141017.h6EAHIlJ094274@freefall.freebsd.org>
Message-ID: <20030714233806.I37788-100000@hewey.af.speednet.com.au>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: grog@freebsd.org
cc: freebsd-bugs@freebsd.org
Subject: Re: bin/47566: Suggested patch: vinum status verification
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Jul 2003 13:47:26 -0000

On Mon, 14 Jul 2003, Kris Kennaway wrote:

> Responsible-Changed-From-To: freebsd-bugs->grog
> Responsible-Changed-By: kris
> Responsible-Changed-When: Mon Jul 14 03:17:04 PDT 2003
> Responsible-Changed-Why:
> Assign to vinum author
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=47566

I like this patch and have been using it for a couple of months on a few
boxes. I have seen it report actual vinum errors which helped diagnose
problems on a box that was playing up here.

There is one error, the diff is backwards:

@@ -33,7 +33,7 @@
         then
             [ $rc -lt 1 ] && rc=1
             echo "$host vinum diffs:"
-            diff -u $bak/vinum.tmp $bak/vinum.bak
+            diff -u $bak/vinum.bak $bak/vinum.tmp
             mv $bak/vinum.bak $bak/vinum.bak2
             mv $bak/vinum.tmp $bak/vinum.bak
         fi


--

 :{ andyf@speednet.com.au

        Andy Farkas
    System Administrator
   Speednet Communications
 http://www.speednet.com.au/