Date: Wed, 13 Apr 2016 20:31:27 -0700 From: Ngie Cooper <yaneurabeya@gmail.com> To: Glen Barber <gjb@freebsd.org> Cc: "O'Connor, Daniel" <darius@dons.net.au>, FreeBSD Hackers <freebsd-hackers@freebsd.org> Subject: Re: Improving commit logs Message-ID: <CAGHfRMCVQvdkM7snsZqhvVYbGx9JnNh6Y0vPCRsZEhNoovEZ6g@mail.gmail.com> In-Reply-To: <20160414032801.GP18163@FreeBSD.org> References: <56FF6534-276E-4E52-871F-5567BD9D6EC7@dons.net.au> <CAGHfRMAwZ-A7BspzCqAEniyQOcy1fmL85V4wjzG0gDBq6gbjtw@mail.gmail.com> <FBAA087E-DCF3-4FB7-922D-A333AD237A23@dons.net.au> <20160414032801.GP18163@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 13, 2016 at 8:28 PM, Glen Barber <gjb@freebsd.org> wrote: > On Thu, Apr 14, 2016 at 12:50:07PM +0930, O'Connor, Daniel wrote: >> >> > On 14 Apr 2016, at 12:28, Ngie Cooper <yaneurabeya@gmail.com> wrote: >> >> Does anyone have any (constructive) comments or feedback? >> > >> > Isn't this just an extension of what others have written up before? >> > Googling "writing good commit messages yielded: >> > >> > 1. http://chris.beams.io/posts/git-commit/ >> > 2. https://robots.thoughtbot.com/5-useful-tips-for-a-better-commit-message >> > >> > This is what I generally try to follow with commits... >> >> Sure, but I think it carries more weight if you can point to a >> specific FreeBSD document and say "do it like this". >> > > As one of the people that has to suffer through delving through commit > logs to find the 'gems', I can personally guarantee that documenting > "how to write good commit messages" will be less than fruitful. Good point: usefulness is in the eye of the beholder. What's good for me to know might be completely irrelevant for someone else.. I guess this is where it helps to get CRs from people who aren't SMEs in the area that you need feedback with.. -Ngie
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMCVQvdkM7snsZqhvVYbGx9JnNh6Y0vPCRsZEhNoovEZ6g>