Date: Wed, 7 Nov 2001 13:02:23 -0800 (PST) From: Julian Elischer <julian@elischer.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: freebsd-arch@FreeBSD.org Subject: Re: Changing req->p to req->td in sysctl Message-ID: <Pine.BSF.4.21.0111071258470.71994-100000@InterJet.elischer.org> In-Reply-To: <Pine.NEB.3.96L.1011107144331.43989B-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 7 Nov 2001, Robert Watson wrote: > > I'm in the process of pushing the (td) reference from ioctl() into > if_ioctl() so that the thread information is available in a number of new > places in the network stack. However, in order to pass it down, we now > need it in a few newer places further up the stack (bpfattach(), ...). this is one of the reasons I left it :-) > One of the places this touches is the sysctl() interface, where the > process is passed in via req->p. The attached patch replaces the proc > reference with a thread reference. Right now, it slightly increases > complexity elsewhere (adds an additional dereference), but when we move to > td->td_ucred, suser using the thread reference, and with the pushing of td > down the stack, this will actually be a net improvement for simplicity. > Please review, I'd like to commit in a day or two. > > Robert N M Watson FreeBSD Core Team, TrustedBSD Project > robert@fledge.watson.org NAI Labs, Safeport Network Services > > ? sys/i386/conf/LINT > Index: sys/compat/linux/linux_mib.c > =================================================================== > RCS file: /home/ncvs/src/sys/compat/linux/linux_mib.c,v Assuming LINT compiles, then This looks fine.... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0111071258470.71994-100000>