From owner-svn-src-stable@freebsd.org Wed Dec 2 11:48:48 2015 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2463EA3EAC2; Wed, 2 Dec 2015 11:48:48 +0000 (UTC) (envelope-from des@des.no) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id 7688F1E4B; Wed, 2 Dec 2015 11:48:47 +0000 (UTC) (envelope-from des@des.no) Received: from desk.des.no (smtp.des.no [194.63.250.102]) by smtp.des.no (Postfix) with ESMTP id 0EE47231E; Wed, 2 Dec 2015 11:48:46 +0000 (UTC) Received: by desk.des.no (Postfix, from userid 1001) id 4371947B04; Wed, 2 Dec 2015 12:48:46 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Baptiste Daroussin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r287084 - in stable/10/usr.sbin/pw: . tests References: <201508232142.t7NLgSXX033227@repo.freebsd.org> Date: Wed, 02 Dec 2015 12:48:46 +0100 In-Reply-To: <201508232142.t7NLgSXX033227@repo.freebsd.org> (Baptiste Daroussin's message of "Sun, 23 Aug 2015 21:42:28 +0000 (UTC)") Message-ID: <867fkxcbq9.fsf@desk.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2015 11:48:48 -0000 Baptiste Daroussin writes: > Log: > MFC: r285133,r285136,r285137,r285156,r285157,r285158,r285256,r285318,r2= 85395, > r285396,r285398,r285401,r285403,r285405,r285406,r285408,r285409,r285411, > r285412,r285413,r285415,r285418,r285430,r285433,r285434,r285442,r285948, > r285984,r285985,r285989,r285996,r285997,r286045,r286047,r286066,r286150, > r286151,r286152,r286154,r286155,r286156,r286157,r286173,r286196,r286197, > r286198,r286199,r286200,r286201,r286202,r286203,r286204,r286210,r286211, > r286217,r286218,r286258,r286259,r286341,r286775,r286982,r286986,r286991, > r286993 >=20=20=20 > Validate most pw inputs. This is a serious regression as the validation code is not locale-aware. I would like to see it reverted and an EN issued. Fixing it correctly will be a major undertaking since it would needs to support multibyte locales. In the meantime, I will have to replace pw on my 10.2 systems with the 10.1 binary. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no