From owner-svn-src-all@FreeBSD.ORG Wed Oct 22 15:04:59 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4EDD510656AF; Wed, 22 Oct 2008 15:04:59 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id E03368FC0A; Wed, 22 Oct 2008 15:04:58 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1KsfGc-00038c-2O; Wed, 22 Oct 2008 18:04:58 +0300 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m9MF4qPf016706 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 22 Oct 2008 18:04:52 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id m9MF4qiC079282; Wed, 22 Oct 2008 18:04:52 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id m9MF4qZc079281; Wed, 22 Oct 2008 18:04:52 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 22 Oct 2008 18:04:52 +0300 From: Kostik Belousov To: "Andrey A. Chernov" Message-ID: <20081022150452.GD94031@deviant.kiev.zoral.com.ua> References: <200810221445.m9MEjUcq031169@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IQ2ZtBPOZQVGoXc0" Content-Disposition: inline In-Reply-To: <200810221445.m9MEjUcq031169@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.93.3, clamav-milter version 0.93.3 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1KsfGc-00038c-2O 575c7730f839cf48cbafa1a1c2796616 X-Terabit: YES Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184161 - head/sys/i386/i386 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2008 15:04:59 -0000 --IQ2ZtBPOZQVGoXc0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 22, 2008 at 02:45:30PM +0000, Andrey A. Chernov wrote: > Author: ache > Date: Wed Oct 22 14:45:30 2008 > New Revision: 184161 > URL: http://svn.freebsd.org/changeset/base/184161 >=20 > Log: > Fix compiler error with missing/unneded ')' >=20 > Modified: > head/sys/i386/i386/identcpu.c >=20 > Modified: head/sys/i386/i386/identcpu.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/i386/i386/identcpu.c Wed Oct 22 10:12:21 2008 (r184160) > +++ head/sys/i386/i386/identcpu.c Wed Oct 22 14:45:30 2008 (r184161) > @@ -842,9 +842,9 @@ printcpuinfo(void) > cpu_feature &=3D ~CPUID_HTT; > =20 > if (!tsc_is_invariant && > - (strcmp(cpu_vendor, "AuthenticAMD") =3D=3D 0 && > - (amd_pminfo & AMDPM_TSC_INVARIANT) !=3D 0 || > - I386_CPU_FAMILY(cpu_id) >=3D 0x10))) { > + ((strcmp(cpu_vendor, "AuthenticAMD") =3D=3D 0 && > + (amd_pminfo & AMDPM_TSC_INVARIANT) !=3D 0) || > + I386_CPU_FAMILY(cpu_id) >=3D 0x10)) { > tsc_is_invariant =3D 1; > printf("\n P-state invariant TSC"); > } Taking apart commit message, I think you change is wrong semantically. Checking CPU_FAMILY without first checking vendor is meaningless. --IQ2ZtBPOZQVGoXc0 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkj/QRMACgkQC3+MBN1Mb4h/ggCg7dqXQJOZEOD/cghLxCA9pK9x 6QkAoOfopbiy1A9LwcCr+DSDHnMBfR/c =YBo5 -----END PGP SIGNATURE----- --IQ2ZtBPOZQVGoXc0--