From owner-svn-ports-all@freebsd.org Fri Jun 19 07:49:52 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4EA7F343049 for ; Fri, 19 Jun 2020 07:49:52 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49p9v31rDLz3SWr for ; Fri, 19 Jun 2020 07:49:50 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by mail-wr1-x433.google.com with SMTP id a6so6743212wrm.4 for ; Fri, 19 Jun 2020 00:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=mInh84zx2nBRcYshR2HoaaqdSWf8ept89kJ0fDuXTl4=; b=2Sm9tPraNsC4+qCOyoOPaEX9uPnMgOxRmCwoN1FGry8UPnhYn7vhcxVFSHb+CJ7tMt 7cpv1lnpGE4azs+1EXcitWPmJ5yFVFLUH1xAz80xPCNJp3jl6fXK/Xye/CCJSJycj11O dsIjQYCd+HmMb9AxszbOJ8pBdG/P1ifzq//QcaAJ/fSqQ4RUtNIS4464WjDL2a36ScdM 9gAGNg8/06fM0ZgdqYzlx2YO7XVijPf1HyW0+0zFi0b9WL4itStuCSNeielc3EfbOosO fcDJYqvLHfkwTJESVYrKRiU/+xeekVAC4UgsAvOYkr4a1dmcHYehJBCg1VKPMYBq/5S3 HhaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mInh84zx2nBRcYshR2HoaaqdSWf8ept89kJ0fDuXTl4=; b=VLUMZ2mGtSlQB64V0F/SFonQMGOZxOY8GTdUa4FWfh2W189jIK3jnpccNPYG9EuoAM 4DHtYGa/7elYXXxLhWNKN6pRDQAx6KrsLe2PtFzChmj77tQNMSqaS+GshEr1tW0ZxWgf Gfs6kp1gYynAFevtymf3XYqvDJPeEkh8miQYca1wpWH9LSMaBU9cswfPUooMNcGL/C5f ztQ5Zv7L2KuZ9/PZaIc+MjRRJfL+FDmzE/7Bu4g5ubeIPEImuub5AuyUj/by8jNK+B4J uBhcNp4NwWrO1dmnPdQnceQhaxFB6huJYtXljqTPvzazbiwVatP/ckxJnRG+9jE+Pced u+Bw== X-Gm-Message-State: AOAM532pYFOQtAoRhwDAzUnFG0brz5sYg2zGIfcvhFJB2oUj2mjGucov 3gymBvksFEeMdWn1Tu+RNIQCHDLOZ17XK272LXLYHg== X-Google-Smtp-Source: ABdhPJzQfMfsJ1VHXGGg/MyzEIkvXu5ZH9i27g8rOjpC2CvwowJnqpgDGCSndGxUtvijnZI9ChviUs7QFc/grAbgL90= X-Received: by 2002:a5d:4ec3:: with SMTP id s3mr2798543wrv.103.1592552989423; Fri, 19 Jun 2020 00:49:49 -0700 (PDT) MIME-Version: 1.0 References: <202006180657.05I6viix040418@repo.freebsd.org> In-Reply-To: From: Adam Weinberger Date: Fri, 19 Jun 2020 01:49:33 -0600 Message-ID: Subject: Re: svn commit: r539531 - in head/security: . vigenere To: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Cc: ports-committers , svn-ports-all , svn-ports-head Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 49p9v31rDLz3SWr X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=adamw-org.20150623.gappssmtp.com header.s=20150623 header.b=2Sm9tPra; dmarc=none; spf=pass (mx1.freebsd.org: domain of adamw@adamw.org designates 2a00:1450:4864:20::433 as permitted sender) smtp.mailfrom=adamw@adamw.org X-Spamd-Result: default: False [-2.87 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.02)[-1.021]; R_DKIM_ALLOW(-0.20)[adamw-org.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; NEURAL_HAM_LONG(-1.01)[-1.010]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-ports-all@freebsd.org]; DMARC_NA(0.00)[adamw.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[adamw-org.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.34)[-0.336]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::433:from]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2020 07:49:52 -0000 On Fri, Jun 19, 2020 at 1:25 AM Fernando Apestegu=C3=ADa wrote: > > On Fri, Jun 19, 2020 at 8:49 AM Adam Weinberger wrote: > > > > On Thu, Jun 18, 2020 at 12:57 AM Fernando Apestegu=C3=ADa > > wrote: > > > +WWW: https://www.olivermahmoudi.com/programming/vigenere-cipher/ > > > > Hi Fernando, > > > > That WWW is 404, and there's no mention of the software on Oliver's web= site. > > Hi Adam! > > I'm pretty sure I checked that, but maybe I missed it?. I will open a > PR asking him about it. > > > > > Is this cipher actively used for modern practical purposes? If not, > > this sounds like a programming exercise and I'm not sure why it'd need > > a port. > > Before including the new port I checked Oliver was the maintainer of > other ports, some of which I had incidentally committed to recently > (sysutils/mapdir). > Some of his ports include security/caesarcipher that I assume nobody > uses for modern practical purposes either :-) It also happens he is > the original writer of the four ports he maintains. > > I read the Committers Guide about new ports > (https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ar= ticle.html#ports-qa-adding) > in search of policy but couldn't find any. > > Should submitters "make a case" for the new port to be included? > Should the committer refuse if he/she evaluates the software is not > useful enough? Yes, that is a central part of the committer's role. Choosing how to shape the ports tree is far more critical than committing the PRs to get there. I don't ask submitters to make a case, but if I reject a PR I certainly give the submitter a chance to change my mind. FreeBSD isn't a museum, and software that nobody is ever going to use places unnecessary burdens on the builders, on end-user ports tree disk space usage, and clutters results when end-users search for software. I'd charitably estimate that 20% of the software in the ports tree was installed in the last year. And maybe 60% over the last 10 years. We could easily take out half the ports and nobody would ever notice. If submitted software appears insufficiently useful, incomplete, or of suspiciously poor quality, please reject it. (I haven't investigated the code here, nor that of any other of Oliver's ports, so I'm not trying to suggest you do so here.) # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org