From owner-freebsd-current@freebsd.org Sat Aug 17 07:46:31 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EE24DBE5B5 for ; Sat, 17 Aug 2019 07:46:31 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 469XLv3N4vz45nt for ; Sat, 17 Aug 2019 07:46:31 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id 71F55BE5B4; Sat, 17 Aug 2019 07:46:31 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 71B12BE5B3 for ; Sat, 17 Aug 2019 07:46:31 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 469XLv2NlCz45ns; Sat, 17 Aug 2019 07:46:31 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wm1-x343.google.com with SMTP id z23so5806259wmf.2; Sat, 17 Aug 2019 00:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=P5/yt50WJ3DfaQIvxi6tHvZqaCHp7huWSjvVzmaN230=; b=QtIOaBH7nUoCAvAooDV4ztBlm+QCD7ZMjzApX4sEPfzkJSu4eIEksTJ1y/yxzTeHmj MPYy3QaxVH5S5V8Et70pDhHA5VVDG5JcRAA/4Yyaz/rvDkthTsez9RcG9yy9/0Tiw77H fjh4xKrM4b49UY3D0Druij2GAw/9GcLF8QWJKIi1yScyz27Dfw/HKIC95N9Axie3uSUY ON1K6BGIzb0YOcsVQd/aGOA/D0HZS1MFL8ReQE4LZ9sSUYA6BWgqe7wmutfdAdyF0Hp1 qSd8SgTjCWW/T4Z1OK90RxjXTe9aXiJpgoMjxnUHD4ckzRZW1L5fPXpx/qX6iMJj1zcG lQNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=P5/yt50WJ3DfaQIvxi6tHvZqaCHp7huWSjvVzmaN230=; b=BHEn9sEzEG+chpTHsu8iYPIUiBvOjj0uwYte9UguKmqaaWAjjP1880HEOYShHj5sx0 dNc21/6FXAhrL4BgBzDKhYvmODfz+Pnb4KuSfeqrazmzbFAVQPb6bK+GMnP7DfenH2Df TXjBlCpCirvBiWrAKe8EzYpv9J5acKRHDyODKNTJNUudwQ6LM5Ov7tnF4AgPCQRK0aMx 6g3btoxOteMV+GnF7XUjc1XFmsmDvwkaNEIAnPE8vKbKXS7lDSxROaGIpoocNVgDcwAh kdlBObhIn7XgiE2v6TipYEU0y2llsjnSt7A7sKTv1wx0Q4ixnaL+tkNFFnvXIY+dsMwO lDVw== X-Gm-Message-State: APjAAAUmHOBKrxFOaenHJQKQFSm/tUS2s4ohiBQCekXtFF58tcPJG1vR bDBRJ+aGF8zrnv1bXa2RXxrMiPyW X-Google-Smtp-Source: APXvYqwoDE1uYa/6D0QCBYFHt2DXSuug8cbg4+Dcu4L6WizmH0TANXTQhOfZujZ/z1619n0yxMXpkw== X-Received: by 2002:a1c:2314:: with SMTP id j20mr10583514wmj.152.1566027989596; Sat, 17 Aug 2019 00:46:29 -0700 (PDT) Received: from ernst.home (p5B3BE66A.dip0.t-ipconnect.de. [91.59.230.106]) by smtp.gmail.com with ESMTPSA id r16sm16429130wrc.81.2019.08.17.00.46.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Aug 2019 00:46:28 -0700 (PDT) Date: Sat, 17 Aug 2019 09:46:27 +0200 From: Gary Jennejohn To: John Baldwin Cc: current@freebsd.org Subject: Re: problem with LOCAL_MODULES Message-ID: <20190817094627.64358949@ernst.home> In-Reply-To: References: <20190816120524.21b7fd19@ernst.home> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 469XLv2NlCz45ns X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.981,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Aug 2019 07:46:32 -0000 On Fri, 16 Aug 2019 17:37:56 -0700 John Baldwin wrote: > On 8/16/19 3:05 AM, Gary Jennejohn wrote: > > I tried to build a kernel today and it failed in modules-all even > > though I had LOCAL_MODULES="" in /etc/src.conf, as recommended by > > jhb. > > > > That's wrong. It has to be LOCAL_MODULES=, otherwise > > /sys/conf/kern.post.mk seems to conclude that there should be a > > module under /usr/local/sys/modules with the name "". > > I think this will permit both versions to work: > > Index: sys/conf/kern.post.mk > =================================================================== > --- kern.post.mk (revision 351151) > +++ kern.post.mk (working copy) > @@ -76,6 +76,7 @@ modules-${target}: > cd $S/modules; ${MKMODULESENV} ${MAKE} \ > ${target:S/^reinstall$/install/:S/^clobber$/cleandir/} > .endif > +.if !empty(LOCAL_MODULES) > .for module in ${LOCAL_MODULES} > @${ECHODIR} "===> ${module} (${target:S/^reinstall$/install/:S/^clobber$/cleandir/})" > @cd ${LOCAL_MODULES_DIR}/${module}; ${MKMODULESENV} ${MAKE} \ > @@ -83,6 +84,7 @@ modules-${target}: > ${target:S/^reinstall$/install/:S/^clobber$/cleandir/} > .endfor > .endif > +.endif > .endfor > > # Handle ports (as defined by the user) that build kernel modules > Nope, the same error as before with the patch applied and LOCAL_MODULES="" . -- Gary Jennejohn