From owner-cvs-src@FreeBSD.ORG  Sat Jan  7 19:29:25 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8597816A41F;
	Sat,  7 Jan 2006 19:29:25 +0000 (GMT) (envelope-from imp@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3C5AE43D48;
	Sat,  7 Jan 2006 19:29:25 +0000 (GMT) (envelope-from imp@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k07JTPLG042379;
	Sat, 7 Jan 2006 19:29:25 GMT (envelope-from imp@repoman.freebsd.org)
Received: (from imp@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k07JTP7x042378;
	Sat, 7 Jan 2006 19:29:25 GMT (envelope-from imp)
Message-Id: <200601071929.k07JTP7x042378@repoman.freebsd.org>
From: Warner Losh <imp@FreeBSD.org>
Date: Sat, 7 Jan 2006 19:29:25 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/dev/sn if_sn.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Jan 2006 19:29:25 -0000

imp         2006-01-07 19:29:25 UTC

  FreeBSD src repository

  Modified files:
    sys/dev/sn           if_sn.c 
  Log:
  While reviewing if_sn in an attempt to understand network drivers
  better, I discovered sn doing too many pointer dereferences.  This
  driver would do silly things like:
          sn_foo(struct ifnet *ifp)
          {
                  struct sn_softc *sc = ifp->if_softc;
  
                  sc->ifp->mumble
                  /* Other stuff */
          }
  
  while /* other stuff */ usually needed sc, the extra deref isn't
  needed.  Eliminate a few dozen of them.
  
  Revision  Changes    Path
  1.52      +34 -34    src/sys/dev/sn/if_sn.c