Date: Wed, 13 Apr 2005 21:19:17 -0400 From: Gregg Cooper <bsdcrank@squbes.com> To: marcus@FreeBSD.org Cc: harti@FreeBSD.org Subject: FreeBSD Port: portlint-2.7.1 Message-ID: <20050414011919.226D743D49@mx1.FreeBSD.org>
next in thread | raw e-mail | index | archive | help
Joe,
You're _fast_!
After skimming your portlint updates, and harti's make parsing code (both
over my head), and the concerns raised over harti's good work, my
quick-n-dirty curiosity-enlightens grep:
find /usr/ports/ -name Makefile -exec grep -H \
'^\.[[:space:]]*\(else\|endif\)\([^[:space:]]\|[[:space:]]\+[^[:space:]#]\)'
\
{} ';'
yields the following (even after harti graciously fixed several ports):
/usr/ports/devel/linux-understand_ada/Makefile:.endif /* NOPORTDOCS */
/usr/ports/devel/linux-understand_c/Makefile:.endif /* NOPORTDOCS */
/usr/ports/devel/linux-understand_java/Makefile:.endif /* NOPORTDOCS */
/usr/ports/mail/dspam/Makefile:. elseif defined(WITH_POSTGRESQL)
/usr/ports/mail/dspam-devel/Makefile:. elseif defined(WITH_POSTGRESQL)
/usr/ports/multimedia/transcode/Makefile:.endif(WITH_AVIFILE)
/usr/ports/net/rp-pppoe/Makefile:.endif /* NOPORTDOCS */
/usr/ports/news/newsx/Makefile:.else !defined(WITHOUT_INN_2-X)
Ports transcode and newsx are probably getting undesired results, but they
put the slip on portlint. I'm sure you aren't interested in full
make/c/ruby/xyz parsing, and a line needs to be drawn somewhere ... but since
you were _so_ fast with the last update, I thought I'd share my learning
experience - along with the commendation!
Gregg
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050414011919.226D743D49>