Date: Mon, 8 Oct 2012 09:16:42 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: svn commit: r305357 - head/net/ssvnc Message-ID: <20121008071642.GA91360@ithaqua.etoilebsd.net> In-Reply-To: <20121008045905.GD91369@FreeBSD.org> References: <201210061123.q96BNHVx053948@svn.freebsd.org> <20121008040154.GB91369@FreeBSD.org> <20121008045905.GD91369@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--TB36FDmn/VVEgNH/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 08, 2012 at 04:59:06AM +0000, Alexey Dokuchaev wrote: > On Mon, Oct 08, 2012 at 04:01:54AM +0000, Alexey Dokuchaev wrote: > > On Sat, Oct 06, 2012 at 11:23:17AM +0000, Baptiste Daroussin wrote: > > > New Revision: 305357 > > > URL: http://svn.freebsd.org/changeset/ports/305357 > > >=20 > > > Log: > > > fix sense of a test > > > =20 > > > -.if ${PORT_OPTIONS:MULTRAFTP} > > > +.if empty(PORT_OPTIONS:MULTRAFTP) > >=20 > > That looks weird, and commit message is pretty cryptic as well. Could = you > > explain what went wrong here so others would not fall in the same pitfa= ll? >=20 > Err, I read is as ! vs. empty() test. Still, I've noticved some arguments > on the syntax, would be nice to know if ! ${PORT_OPTIONS:M...} has issues > other than purely stylish. >=20 No it hasn't (as far as I know) Bapt --TB36FDmn/VVEgNH/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlByfdoACgkQ8kTtMUmk6ExlTQCdHHEfLgnyFE1Vax5xlqTYuDtJ w+gAoKN2jVhTeXWiChZPhhYEEBs9C9j/ =qP1w -----END PGP SIGNATURE----- --TB36FDmn/VVEgNH/--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121008071642.GA91360>