From owner-svn-ports-head@FreeBSD.ORG Mon Nov 10 17:07:28 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DAF3DF3D; Mon, 10 Nov 2014 17:07:28 +0000 (UTC) Received: from mail-ob0-x22e.google.com (mail-ob0-x22e.google.com [IPv6:2607:f8b0:4003:c01::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9B420E29; Mon, 10 Nov 2014 17:07:28 +0000 (UTC) Received: by mail-ob0-f174.google.com with SMTP id uz6so5977134obc.19 for ; Mon, 10 Nov 2014 09:07:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=US+DnRiJSdZrUfaVc6MGOA/9+xsxhUq6SCWqqTu1Pcc=; b=0EI5TR9G9HY+BfZAcUSmqUibxzzsbaieAFsToYgnz4wUXE55xiMDx3Riqr5ieKDy6A E2HbOeO7rz9EKfaArYmtF+/E+PKoSCxLaAb+4mak1o3taCNkaVmkub7J0pYevEUunxyh 3onAoDwv7bhAjjqvJsX3pPBSu+uj6fO3Uv4PY9EwYk+e29IuUC0iKcN7wCkuEgjd0pMj A5GXnJw2ocqT7RpTQvDpob9OeyhO88ezJlmETxLO794UeTBmUM05NynUkjEHMUdDevo3 Us66h412kVYHy23dkgSxhLhIfAQMUWhkMmodvV3w1vRkS3w+qT3a+tidjVx4MvueRD6K ai/A== MIME-Version: 1.0 X-Received: by 10.202.102.215 with SMTP id m84mr2797140oik.67.1415639247802; Mon, 10 Nov 2014 09:07:27 -0800 (PST) Sender: andrej.zverev@gmail.com Received: by 10.182.139.9 with HTTP; Mon, 10 Nov 2014 09:07:27 -0800 (PST) In-Reply-To: <201411101505.sAAF53Kj011471@svn.freebsd.org> References: <201411101505.sAAF53Kj011471@svn.freebsd.org> Date: Mon, 10 Nov 2014 21:07:27 +0400 X-Google-Sender-Auth: sAJAyXZdYCJFjC1-lZAmETL-Auk Message-ID: Subject: Re: svn commit: r372397 - head/devel/p5-Config-Any From: Andrej Zverev To: Philippe Audeoud Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Nov 2014 17:07:29 -0000 Hi, i did some later changes in this port. I don't agree with this patch, since it only adds depend based on fact what 'make test' target doesn't work for submitter, but our ports tree and this port itself don't support 'make test'. While I agree with fact what 'Module::Pluggable' already deprecated in 5.20, we need depend on it explicit. I hope now my 'why i did it' is more clear :-) On Mon, Nov 10, 2014 at 6:05 PM, Philippe Audeoud wrote: > Author: jadawin > Date: Mon Nov 10 15:05:02 2014 > New Revision: 372397 > URL: https://svnweb.freebsd.org/changeset/ports/372397 > QAT: https://qat.redports.org/buildarchive/r372397/ > > Log: > - Add p5-Module-Pluggable as depends > - Add licence > > PR: ports/194926 > Submitted by: Henk van Oers > > Modified: > head/devel/p5-Config-Any/Makefile > > Modified: head/devel/p5-Config-Any/Makefile > > ============================================================================== > --- head/devel/p5-Config-Any/Makefile Mon Nov 10 14:23:12 2014 > (r372396) > +++ head/devel/p5-Config-Any/Makefile Mon Nov 10 15:05:02 2014 > (r372397) > @@ -3,6 +3,7 @@ > > PORTNAME= Config-Any > PORTVERSION= 0.24 > +PORTREVISION= 1 > CATEGORIES= devel perl5 > MASTER_SITES= CPAN > PKGNAMEPREFIX= p5- > @@ -10,7 +11,11 @@ PKGNAMEPREFIX= p5- > MAINTAINER= perl@FreeBSD.org > COMMENT= Load class configuration data from a number of file formats > > -BUILD_DEPENDS= p5-Config-General>=2.47:${PORTSDIR}/devel/p5-Config-General > +LICENSE= ART10 GPLv1 > +LICENSE_COMB= dual > + > +BUILD_DEPENDS= > p5-Config-General>=2.47:${PORTSDIR}/devel/p5-Config-General \ > + > p5-Module-Pluggable>=0:${PORTSDIR}/devel/p5-Module-Pluggable > RUN_DEPENDS:= ${BUILD_DEPENDS} > > OPTIONS_DEFINE= INI JSON XML YAML > >