From nobody Sun Oct 5 13:13:29 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cfjWs52hVz69s3g; Sun, 05 Oct 2025 13:13:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cfjWs2Y9wz3pxN; Sun, 05 Oct 2025 13:13:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759670009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2F4TFp2I5WcPxjLY4lHYsf/+n9xzlQEr313UQx+GPaE=; b=pOUX9nS18l7kr7oVy/f0gBoj9Fw13N6bA7xhK+mhDBV5XYBOLTYq4rZjWqb9svFwhbGOIo +1mfn4s8xQDEZgqQsb9z6nGRB11XoesU/sqT/8IGYayQ3gA12LeM2EHzIy1jnZkZ9ulXnS 9lduCOYBAFggU4HShXxXaEnuc6T4N8WPrO5KKv7qSjzPgyhEWdxtdzCup7XkXuxvh2fL0X rdRfts3tn2nOcD7oYypxa9gZqmIGnzuZ7gSuXfPhLIxjLXoBOGdaTpsjClIPlfjKYRDouR recEuwKsw+E80OeWJqKGY37iPCVZYioxmb9cGyfdfsJU2S+yCe9/zyPIZQn8yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759670009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2F4TFp2I5WcPxjLY4lHYsf/+n9xzlQEr313UQx+GPaE=; b=esRWCpxkqPBX2cfvukp5ir6rJP8dqyW9cbwCsV6BeQDeTbLuwn8X+G1vAaWy0BwNSQNpAr s1pfZWPSPPrliIgiGHODpDrL/IEe2y1SAJZWjroT8KRQnEp8IXiEfApQjwJEsAbsVMb4Uz bjIbgCLLJ7Dk68TL3/vfgDE0VSlYBgsUyqtG54r4hu6HGcJAsi0ihPCxgTBPUMkkj+dgwl 2WO9H1omMJlLv6vMRrXBpttHn09YR635ZVCVnhQvaZJAAEmoIJgz7uT5UmxBBo1e39wSht 3hsYsWtznjUS58VAyX+2vEK44QjYA/rsw0JEIvaeV5o9F6iAYIgWNIZS5Ix5sQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759670009; a=rsa-sha256; cv=none; b=wlDTFVQdz6xK/1Tk6/1LoRYa8bQAh+i/oufeG4r/lL691z6rTUBuvgflFAawU2pFcmI+aQ gRGHxXYPEgfO/U9aEeshU1U2orrfduhHp4ZORye1j3LYFamF1bCn62D5p+aitF5eDDTPBY gqnksLYsZqYzed7NZNn+DxJDrwQIUkMPBCQ6wVbPQaV12LzRXisTrW3wMhOD3cVHfiqLdZ SY/i6fIfbDRUKeZORJagancbG3iUv/Ujq+00UvmWC4A+30SjpgBg2yDILfbWX1dtsvIfEa KbPVYKGKmlfJJQq72p59uU1GrhcPkCH1U8zxp2VD5fmn0XyEXXrGI+w13bzLyg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cfjWs284fz1SFS; Sun, 05 Oct 2025 13:13:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 595DDT5P075137; Sun, 5 Oct 2025 13:13:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 595DDT56075134; Sun, 5 Oct 2025 13:13:29 GMT (envelope-from git) Date: Sun, 5 Oct 2025 13:13:29 GMT Message-Id: <202510051313.595DDT56075134@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 239fb1ad8e73 - stable/14 - pw: Print warnings when metadata updates fail List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 239fb1ad8e7336f4c9208828d926525be763d374 Auto-Submitted: auto-generated The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=239fb1ad8e7336f4c9208828d926525be763d374 commit 239fb1ad8e7336f4c9208828d926525be763d374 Author: Mark Johnston AuthorDate: 2025-09-18 22:38:33 +0000 Commit: Mark Johnston CommitDate: 2025-10-05 13:13:00 +0000 pw: Print warnings when metadata updates fail We do this in most places already, but not consistently. MFC after: 1 week Sponsored by: The FreeBSD Foundation Sponsored by: Klara, Inc. (cherry picked from commit daa63c9417a28ad08881ff03df828fd8180dad12) --- usr.sbin/pw/cpdir.c | 6 ++++-- usr.sbin/pw/pw_user.c | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/usr.sbin/pw/cpdir.c b/usr.sbin/pw/cpdir.c index 3dee8f7c43ac..63068cab000c 100644 --- a/usr.sbin/pw/cpdir.c +++ b/usr.sbin/pw/cpdir.c @@ -127,8 +127,10 @@ copymkdir(int rootfd, char const * dir, int skelfd, mode_t mode, uid_t uid, /* * Propagate special filesystem flags */ - fchown(destfd, uid, gid); - fchflags(destfd, st.st_flags); + if (fchown(destfd, uid, gid) != 0) + warn("chown(%s)", p); + if (fchflags(destfd, st.st_flags) != 0) + warn("chflags(%s)", p); close(destfd); } closedir(d); diff --git a/usr.sbin/pw/pw_user.c b/usr.sbin/pw/pw_user.c index 8a9a4342f5ef..9f5cfb0f4473 100644 --- a/usr.sbin/pw/pw_user.c +++ b/usr.sbin/pw/pw_user.c @@ -123,7 +123,8 @@ mkdir_home_parents(int dfd, const char *dir) if (fstatat(dfd, dirs, &st, 0) == -1) { if (mkdirat(dfd, dirs, _DEF_DIRMODE) == -1) err(EX_OSFILE, "'%s' (home parent) is not a directory", dirs); - fchownat(dfd, dirs, 0, 0, 0); + if (fchownat(dfd, dirs, 0, 0, 0) != 0) + warn("chown(%s)", dirs); } free(dirs);