From owner-svn-ports-all@freebsd.org Fri Jun 19 08:04:34 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D3D02343854; Fri, 19 Jun 2020 08:04:34 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-vs1-f67.google.com (mail-vs1-f67.google.com [209.85.217.67]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49pBD20SVJz3Tdj; Fri, 19 Jun 2020 08:04:33 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: by mail-vs1-f67.google.com with SMTP id q2so5129772vsr.1; Fri, 19 Jun 2020 01:04:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wR23mtTzFzdz552eSxLHA1+T0LVWkQBdeiu1KEKw7Nk=; b=bMZHm1+HJWG3vTHS8RSz4Xn5Ibtls86oOceYVlM4/NbZ2xlTsljlsR4A0OXO8r1BSt G1NECl4wyBOpQXV2+1TqeChh5ARWhhI9Jkp752GCL4vVSlvIZH5Zzys3XVFAGU6NaE1q j/pKy48q1rNejB83Im6L64ngWyzPUD+2xwlvAD6bJEjujoiXhHHDhTLA53pkLkOgB9Q2 k9VWEUcQxMPhFnlrjE3n9p3CXDtbH8Lq9Ljint6UQvyReiD5iu4cPBAFPDa9LJIR4VOx HpVqzOeKjtJg2uXKUKNPDfPs50+P4uzQDyB2wnpBc+QOrsRJNLWWMTKDaPv9YblIuNaf rusQ== X-Gm-Message-State: AOAM532lqIAldC9CbKJzm26WCG83qGFOfbVuIZtCn7rbtZS3np2UBCd5 y1B2BCK7FDLlw1WyPuhdag8Besbx8Ew= X-Google-Smtp-Source: ABdhPJxJHOoPYi0GqVU2X0e32Pvjs1ydQX6e94n1XSys+rbOAjrCgKRFi94NiyUkHaovUKsineL3WA== X-Received: by 2002:a67:70c3:: with SMTP id l186mr6632056vsc.117.1592553872862; Fri, 19 Jun 2020 01:04:32 -0700 (PDT) Received: from mail-vk1-f176.google.com (mail-vk1-f176.google.com. [209.85.221.176]) by smtp.gmail.com with ESMTPSA id s22sm674101vkd.35.2020.06.19.01.04.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2020 01:04:32 -0700 (PDT) Received: by mail-vk1-f176.google.com with SMTP id d5so2084565vkb.12; Fri, 19 Jun 2020 01:04:32 -0700 (PDT) X-Received: by 2002:a1f:a8d0:: with SMTP id r199mr6253040vke.26.1592553872416; Fri, 19 Jun 2020 01:04:32 -0700 (PDT) MIME-Version: 1.0 References: <202006180657.05I6viix040418@repo.freebsd.org> In-Reply-To: From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Fri, 19 Jun 2020 11:04:02 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r539531 - in head/security: . vigenere To: Adam Weinberger Cc: ports-committers , svn-ports-all , svn-ports-head Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 49pBD20SVJz3Tdj X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of fernandoapesteguia@gmail.com designates 209.85.217.67 as permitted sender) smtp.mailfrom=fernandoapesteguia@gmail.com X-Spamd-Result: default: False [-2.37 / 15.00]; RCVD_TLS_ALL(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-0.97)[-0.965]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.46)[-0.465]; RCVD_IN_DNSWL_NONE(0.00)[209.85.217.67:from]; NEURAL_HAM_MEDIUM(-0.94)[-0.937]; FORGED_SENDER(0.30)[fernape@freebsd.org,fernandoapesteguia@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.217.67:from]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[fernape@freebsd.org,fernandoapesteguia@gmail.com] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2020 08:04:34 -0000 On Fri, Jun 19, 2020 at 9:49 AM Adam Weinberger wrote: > > On Fri, Jun 19, 2020 at 1:25 AM Fernando Apestegu=C3=ADa wrote: > > > > On Fri, Jun 19, 2020 at 8:49 AM Adam Weinberger wrote= : > > > > > > On Thu, Jun 18, 2020 at 12:57 AM Fernando Apestegu=C3=ADa > > > wrote: > > > > +WWW: https://www.olivermahmoudi.com/programming/vigenere-cipher/ > > > > > > Hi Fernando, > > > > > > That WWW is 404, and there's no mention of the software on Oliver's w= ebsite. > > > > Hi Adam! > > > > I'm pretty sure I checked that, but maybe I missed it?. I will open a > > PR asking him about it. > > > > > > > > Is this cipher actively used for modern practical purposes? If not, > > > this sounds like a programming exercise and I'm not sure why it'd nee= d > > > a port. > > > > Before including the new port I checked Oliver was the maintainer of > > other ports, some of which I had incidentally committed to recently > > (sysutils/mapdir). > > Some of his ports include security/caesarcipher that I assume nobody > > uses for modern practical purposes either :-) It also happens he is > > the original writer of the four ports he maintains. > > > > I read the Committers Guide about new ports > > (https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/= article.html#ports-qa-adding) > > in search of policy but couldn't find any. > > > > Should submitters "make a case" for the new port to be included? > > Should the committer refuse if he/she evaluates the software is not > > useful enough? > > Yes, that is a central part of the committer's role. Choosing how to > shape the ports tree is far more critical than committing the PRs to > get there. I don't ask submitters to make a case, but if I reject a PR > I certainly give the submitter a chance to change my mind. > > FreeBSD isn't a museum, and software that nobody is ever going to use > places unnecessary burdens on the builders, on end-user ports tree > disk space usage, and clutters results when end-users search for > software. I'd charitably estimate that 20% of the software in the > ports tree was installed in the last year. And maybe 60% over the last > 10 years. We could easily take out half the ports and nobody would > ever notice. > > If submitted software appears insufficiently useful, incomplete, or of > suspiciously poor quality, please reject it. (I haven't investigated > the code here, nor that of any other of Oliver's ports, so I'm not > trying to suggest you do so here.) OK, I will do it. Thanks for the clarification. For reference, the PR requesting fixing security/vigenere WWW is https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D247404 Cheers > > # Adam > > > -- > Adam Weinberger > adamw@adamw.org > https://www.adamw.org