From owner-freebsd-net@FreeBSD.ORG Sun Apr 11 07:04:50 2004 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 260ED16A4CE; Sun, 11 Apr 2004 07:04:50 -0700 (PDT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 34EA643D48; Sun, 11 Apr 2004 07:04:49 -0700 (PDT) (envelope-from ru@ip.net.ua) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i3BE9O4O079080 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 11 Apr 2004 17:09:26 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.12.11/8.12.11) id i3BE4j8U038127; Sun, 11 Apr 2004 17:04:45 +0300 (EEST) (envelope-from ru) Date: Sun, 11 Apr 2004 17:04:45 +0300 From: Ruslan Ermilov To: Luigi Rizzo Message-ID: <20040411140445.GA38033@ip.net.ua> References: <20040410222112.GA23046@ip.net.ua> <20040411023124.A83988@xorpc.icir.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Nq2Wo0NMKNjxTN9z" Content-Disposition: inline In-Reply-To: <20040411023124.A83988@xorpc.icir.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: net@freebsd.org Subject: Re: Per-interface polling(4) status X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Apr 2004 14:04:50 -0000 --Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 11, 2004 at 02:31:24AM -0700, Luigi Rizzo wrote: > more or less i am fine with your proposed change. >=20 OK. > I believe you could add something to state the capability of the=20 > hw/driver (polling-capable, like checksum-offloading). >=20 I have no idea why I haven't thought about interface capabilities, but that's certainly what I was looking for, thanks! Since this was very easy to implement, and it also didn't require change to basic polling code (the IFF_POLLING has the old meaning and semantics), I went ahead and committed my updated changes to HEAD. > POLA would suggest to set IFF_POLLING by default on all drivers which > support it. You still need the global sysctl to enable it. > =20 The new IFCAP_POLLING will be set by default in enabled capabilities list, except probably in the rl(4) driver. ;) > Finally, while you are at it (and before we branch 6.0), maybe you=20 > could store the 'IFF_CANTCHANGE' flags in a separate place from=20 > user-configured ones, so one wouldn't have to apply the mask all > the times. >=20 Is it really "all the time"? The use of IFF_CANTCHANGE is currently limited to only two files in sys/net/, if I'm not terribly mistaken. Anyway, let's continue discussion of this item in a separate thread. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --Nq2Wo0NMKNjxTN9z Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAeVB9Ukv4P6juNwoRAmVbAJ9CR6ncq5NiIZ0I9V8OfsvEJkrWCQCeL1m6 SNya+RbYGNIe8oudOnU1JCc= =cWz8 -----END PGP SIGNATURE----- --Nq2Wo0NMKNjxTN9z--