Date: Sun, 11 Apr 2004 17:04:45 +0300 From: Ruslan Ermilov <ru@freebsd.org> To: Luigi Rizzo <luigi@freebsd.org> Cc: net@freebsd.org Subject: Re: Per-interface polling(4) status Message-ID: <20040411140445.GA38033@ip.net.ua> In-Reply-To: <20040411023124.A83988@xorpc.icir.org> References: <20040410222112.GA23046@ip.net.ua> <20040411023124.A83988@xorpc.icir.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 11, 2004 at 02:31:24AM -0700, Luigi Rizzo wrote: > more or less i am fine with your proposed change. >=20 OK. > I believe you could add something to state the capability of the=20 > hw/driver (polling-capable, like checksum-offloading). >=20 I have no idea why I haven't thought about interface capabilities, but that's certainly what I was looking for, thanks! Since this was very easy to implement, and it also didn't require change to basic polling code (the IFF_POLLING has the old meaning and semantics), I went ahead and committed my updated changes to HEAD. > POLA would suggest to set IFF_POLLING by default on all drivers which > support it. You still need the global sysctl to enable it. > =20 The new IFCAP_POLLING will be set by default in enabled capabilities list, except probably in the rl(4) driver. ;) > Finally, while you are at it (and before we branch 6.0), maybe you=20 > could store the 'IFF_CANTCHANGE' flags in a separate place from=20 > user-configured ones, so one wouldn't have to apply the mask all > the times. >=20 Is it really "all the time"? The use of IFF_CANTCHANGE is currently limited to only two files in sys/net/, if I'm not terribly mistaken. Anyway, let's continue discussion of this item in a separate thread. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --Nq2Wo0NMKNjxTN9z Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAeVB9Ukv4P6juNwoRAmVbAJ9CR6ncq5NiIZ0I9V8OfsvEJkrWCQCeL1m6 SNya+RbYGNIe8oudOnU1JCc= =cWz8 -----END PGP SIGNATURE----- --Nq2Wo0NMKNjxTN9z--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040411140445.GA38033>