From owner-svn-ports-all@freebsd.org Mon Mar 23 11:04:08 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AE05427F894; Mon, 23 Mar 2020 11:04:08 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48mBMr3nx5z4dQ3; Mon, 23 Mar 2020 11:04:08 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [IPv6:2a01:678:4:1::228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 42B7B1C30C; Mon, 23 Mar 2020 11:04:08 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:678:42:0:5e80:b6ff:fe2c:99e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 31894942E97; Mon, 23 Mar 2020 11:04:05 +0000 (UTC) Date: Mon, 23 Mar 2020 12:04:28 +0100 From: Mathieu Arnold To: Gerald Pfeifer Cc: Mathieu Arnold , John Hixson , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r528808 - head/net/nsq Message-ID: <20200323110428.jp6up6ijyozpbv5h@aching.in.mat.cc> References: <202003202245.02KMjo5Z005946@repo.freebsd.org> <20200321172227.zn7i4ov6vkvtboii@aching.in.mat.cc> <20200322083237.vaqvidavvdu2jrcj@atuin.in.mat.cc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="634bdo5saplgapo4" Content-Disposition: inline In-Reply-To: X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2020 11:04:08 -0000 --634bdo5saplgapo4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 22, 2020 at 12:20:58PM +0100, Gerald Pfeifer wrote: > Hi Mat, >=20 > On Sun, 22 Mar 2020, Mathieu Arnold wrote: > >>>> +PORTREVISION=3D 2 > >>> Why bump PORTREVISION? > >> John, as a bit more color: when a commit solely allows a port to build= =20 > >> that failed to build before, or build where it did not build before (O= S=20 > >> version, architecture,...) we don't usually bump PORTREVISION. > > I do not understand what is so hard with understanding why PORTREVISION > > exists. >=20 > was this directed at me, or a general note? >=20 > If the former, yes, I could (should) have omitted the word "usually" > since I had "solely" at the beginning of the sentence. Apart from=20 > that softness, I don't sense disagreement; is there? It was not directed at you. My point is that we define usage as things that needs to be done, not things that needs to not be done. Like, "you use PORTREVISION when the package version does not change and needs to be rebuilt", not like "You do not use PORTREVISION in X case". --=20 Mathieu Arnold --634bdo5saplgapo4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAl54l69fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgKvRBAAkFhf9ReXQ/S11IgowRolAuWMyKYn/Q+6wvGzZySdFu5J1LXX+L0A3qLl 4YWLQkZnQN4IHVAZcV8MZrNatGIYRaCH6EKvIK09K9hMMxk+ttnyaIkRYxC7bLId ovT2C4xEHgAvR4HwcaFacNuh88Afp2wwwCr+25luBUQzvb2xSrTqXACI8gdWdgL2 RCd4/dhAsCvX2b5pnOWh6IYHooMyJNiLSYRVVSbindCB4GutPClvR+WhrIxraMH1 0+UaOhip4Cco95X4uW/2jPsVcAMrs9mgFDEl6qbsdDCQkOLhiscvfFdrBIurCJ3S 8HCAGdXQ+xFG9sWYSnrnWSvH3JDWStXPh34Vnz4yF2qz3K0vQ+Ge84u9HNic3rWg FVLtQWOpf+cSLg2QtnNg70gdIa4i/vGeB0KZxG8UlVqnP6h6Vu96GN6DWmSGRRCY fIHW3sXebvuJGMGtw+Kckf33qM/iQQDx5hop4F5dTitdujLkzZ0B+0wu1TPjZQHe d4TD83wTMtf/RewDald0FvTMumWj2Bf6jUymCfVRgFAtcgkR7aBvFT2Eb1cfyJ4h O6Q2Ur2nGbv5jGo/2NWiTmgqQyPRhYoX951sdsmyJNDPSdOLh0V/U2E1Iz3xbsLa A7CR0R41TTVGRYF7K/gTMcnRkPQMwER99j5gA8B6/EeJlhe8kW0= =W5xx -----END PGP SIGNATURE----- --634bdo5saplgapo4--