From owner-cvs-all Wed Sep 26 12:57: 6 2001 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 62EB437B422; Wed, 26 Sep 2001 12:56:59 -0700 (PDT) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id FAA22080; Thu, 27 Sep 2001 05:56:56 +1000 Date: Thu, 27 Sep 2001 05:56:23 +1000 (EST) From: Bruce Evans X-X-Sender: To: John Baldwin Cc: , Subject: RE: cvs commit: src/sys/sys _lock.h lock.h In-Reply-To: Message-ID: <20010927054324.Q40707-100000@delplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 26 Sep 2001, John Baldwin wrote: > On 25-Sep-01 John Baldwin wrote: > > jhb 2001/09/25 16:51:54 PDT > > > > Modified files: > > sys/sys _lock.h lock.h > > Log: > > Move the definition of LOCK_DEBUG from sys/lock.h to sys/_lock.h. > > This fixes the panic on the vnode interlock. The problem is that vfs_vnops.c > wasn't including sys/lock.h, so LOCK_DEBUG wasn't defined, so it wasn't getting > LOCK_DEBUG defined properly and was just inling the mutex operation and not > calling witness. Arguably, I should cause the compile to break when mutex.h is > included w/o lock.h, but this will work for now. Also, getting LOCK_DEBUG > right really depends on knowing the value of KTR_COMPILE which requires > including sys/ktr.h, so in theory sys/_lock.h should either include sys/ktr.h > or mandate it's inculsion in the _KERNEL case. Bruce, do you have any > preferences on this? Including in would defeat the point of having . Try to make things break if LOCK_DEBUG is used and the prerequisites for getting it right are not included. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message