From nobody Thu Apr 11 19:03:05 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VFpxW5Kbzz5HvYg; Thu, 11 Apr 2024 19:03:11 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VFpxW3kl5z4l0g; Thu, 11 Apr 2024 19:03:11 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712862191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tbaxwmvnP0qOt9GSZ7dObryU1L9rBJi2THvwJw1gk+4=; b=ZHCfAiUEHeEy1/W+Jx+eKjgfUT97YC4pbK7Kyk6AIaYXSPOi9iGBzgSkrK1Q2gJQqo3qLR HMIaQLkYgP2/Nu6UHkfYq+C4BhrmnxrfnXM9VkrXMAvZwFrz31m7wpLXF2r/RTyHJV8qgt OIcihYbl94SPzTG4em7NyVLtKulJ4nXwmzUqFthhAGdy+lPCRZrEplZ/8OSCdD2h1nfJFw 1E9U9WgEzPIEPW2cDO8ePfECYxDMF0pf2XR6I1Vn40YeHgQtJuESTAQC4ul026izI/CBlg f80SshseIF9u2zHKDPCnL/BOCWqgaUZOHInBLEsGw14zEgMoTBfWABOBcvpANw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1712862191; a=rsa-sha256; cv=none; b=uulQM25t6jEE3Sf9Ssmkge4hUGZ9fMGSq15gdw2obueQHLq8lXC8j7PvAS8iYvd5N15tY+ rb9fUxY0GXutopwWjz/OC5Dx08Pag2qnSYgvL4O87bVoZhXavHZJ/qMXdCvq/aLX38+9qh Bq/G8s7UEyItHFAoB1ZISHOjeZRE7/FBK8aFQlcdHY4Xge06TU9KlkugbdahLtOa2CiKAs CbhDdcVcyGnD6NrwINGazj/oTFJCFlZzm1zsgm21l3ctzHh6KKSbOhe2fTo7tIww4XKyuf WKKAVK6kl3jPgnIaEmzNxpJyBr2pTqEtKVjLiDzWoatLRoiiwCIVChToRO6DDg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712862191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tbaxwmvnP0qOt9GSZ7dObryU1L9rBJi2THvwJw1gk+4=; b=rJ/7wj1hv4l8TzudWuvZtNgarMTuQzDyJUvY3IhfKrkCMJKAWTBCh8Y+geGtR0T3NcJ+dI HON7NpwpY5IHp3nrziUM+2m9ogpXZztJS0YBou3i+i51MkDGFb7QTbTREDhHLlKnWFd73l XsM1eMu4VSJ0rkjgM/HZuOUOk5sGiSD7Z0XMYezri04qYUz3I4HAm/YUCBSFBXVI2bYOvj 0JHaVK98LEJTD9h5346Qa+uabhy6HApZxIZzRhUl4fCFRtdcK78CrrLL9InNPz1L7GYVYH tAbmgAtrUaB1p4L5Z0TSHnTgu8cl2B6NHh3DL1219z64XdpXqSxwFlKqva2aDA== Received: from relay.mat.cc (eqx1.mat.cc [IPv6:2a01:678:2:200::49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "cow.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VFpxW2lPhz1Ftm; Thu, 11 Apr 2024 19:03:11 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:e0a:836:f670:2a6c:1fc1:e115:d7e7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by relay.mat.cc (Postfix) with ESMTPSA id 35230214A2; Thu, 11 Apr 2024 21:03:07 +0200 (CEST) Date: Thu, 11 Apr 2024 21:03:05 +0200 From: Mathieu Arnold To: Gleb Popov Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 665b0219e541 - main - Mk/Uses: Fix feature checks after my previous {WITH,WITHOUT}_*_PORTS change Message-ID: References: <202404111754.43BHsjgV004072@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: dev-commits-ports-all+owner@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6wvezb7w6j36tdnm" Content-Disposition: inline In-Reply-To: <202404111754.43BHsjgV004072@gitrepo.freebsd.org> --6wvezb7w6j36tdnm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, I'm picking on one hunk but they all look similar. On Thu, Apr 11, 2024 at 05:54:45PM +0000, Gleb Popov wrote: > -. if !defined(WITH_DEBUG) > +. if !defined(_WITH_DEBUG) I don't really understand, is WITH_DEBUG gone ? Because that cannot be. There are a gazillion of ports that do stuff when WITH_DEBUG. If I set WITH_DEBUG_PORTS+=3Ddns/bind918, and then I build dns/bind918, I assume that WITH_DEBUG will be set in that port. $ make -C dns/bind918 -V USE_PERL5 $ make -C dns/bind918 -V USE_PERL5 WITH_DEBUG=3Dy build $ make -C dns/bind918 -V USE_PERL5 WITH_DEBUG_PORTS=3Ddns/bind918 So, you broke WITH_DEBUG_PORTS :( Can you please immediately revert this commit (665b0219e541) and the one that broke it to begin with ? --=20 Mathieu Arnold --6wvezb7w6j36tdnm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmYYM+hfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb7bBgv+LLKfIeTcQKGI0W6wNL87tzu+gmTODTN0yGHLyItuxmFJssbg75mN+ge9 9WvRahngj/PUNkBFerpHiBTCEnLOVCvMcxnKgRntMlDFJqzotd1SeVZ6KsO45v6N h4La6FQJRJ5tNsrRj5bcpGsZ9KFMON0XOCCwvXwKUsoz72Il189hlAIAVNi7TcJP GdrnW7IKmu7Xzh4mElYORV+1knVHpZhtCfXGo2uUG6NOr6nP40BWwdJyNSeUDIt7 JU10chHm0M7ayQCbVHE5kfUa+fwEn+uZl0gk9KwCj3UFnbers1zzMga0J356kLN5 2Xs95AVlQDCxdoyY4dW8/PXMZtWL8UZ6TJPMZV9T5djAcRmgv8OdhRGBGyeSH642 qxTGdnC+mNomSf/fTBi/adAFWqxwNX7T88Srm/1RAZcy7gUMxo/zMnn9oLDTOs0N /xRcnHg1gNddj4irD2Fp7RT6worfJlD459DQRbPQbMBaf/wrJTqytywBxS5whRBg dgiVDMro =QQ3U -----END PGP SIGNATURE----- --6wvezb7w6j36tdnm--