From owner-freebsd-stable Sat Sep 14 20:18: 6 2002 Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5922337B405 for ; Sat, 14 Sep 2002 20:18:03 -0700 (PDT) Received: from mail.speakeasy.net (mail12.speakeasy.net [216.254.0.212]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D1A443E7B for ; Sat, 14 Sep 2002 20:18:02 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 8103 invoked from network); 15 Sep 2002 03:18:02 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail12.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 15 Sep 2002 03:18:02 -0000 Received: from laptop.baldwin.cx (laptop.baldwin.cx [192.168.0.4]) by server.baldwin.cx (8.12.5/8.12.5) with ESMTP id g8F3I1Bv049707; Sat, 14 Sep 2002 23:18:01 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Sat, 14 Sep 2002 23:18:02 -0400 (EDT) From: John Baldwin To: Tim Zingelman Subject: RE: missing break in recent patch to agp_i810.c Cc: stable@freebsd.org, re@freebsd.org, anholt@freebsd.org Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 15-Sep-2002 Tim Zingelman wrote: > My I810 system broke and gave this message... > > agp0: unknown memory configuration, disabling > device_probe_and_attach: agp0 attach returned 22 > > with the 1.1.2.4 revision of agp_i810.c. A little investigation shows > there is clearly a missing 'break;' in a switch statement. The following > patch fixes it. > > --- agp_i810.c.RELENG_4 Sat Sep 14 19:27:10 2002 > +++ agp_i810.c Sat Sep 14 20:56:16 2002 > @@ -219,6 +219,7 @@ > case 0x71258086: > case 0x11328086: > sc->chiptype = CHIP_I810; > + break; > case 0x35778086: > case 0x25628086: > sc->chiptype = CHIP_I830; > > Release engineering please consider commit approval for this fix. Certainly! Approved conditional on Eric's consent. Thanks for testing this and tracking this down. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message