From owner-freebsd-bugs@FreeBSD.ORG  Fri Jul 30 06:20:36 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EDCAA16A4CF
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 30 Jul 2004 06:20:36 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C39F243D62
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 30 Jul 2004 06:20:36 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i6U6KCJS091282
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 30 Jul 2004 06:20:12 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i6U6KCAM091280;
	Fri, 30 Jul 2004 06:20:12 GMT
	(envelope-from gnats)
Resent-Date: Fri, 30 Jul 2004 06:20:12 GMT
Resent-Message-Id: <200407300620.i6U6KCAM091280@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Takayuki Sakuma <takayuki@finet.fujitsu.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B51FB16A4CE
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri, 30 Jul 2004 06:14:54 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AA0A743D49
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri, 30 Jul 2004 06:14:54 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i6U6E2sc087851
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 30 Jul 2004 06:14:02 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.11/8.12.11/Submit) id i6U6E2Ps087850;
	Fri, 30 Jul 2004 06:14:02 GMT
	(envelope-from nobody)
Message-Id: <200407300614.i6U6E2Ps087850@www.freebsd.org>
Date: Fri, 30 Jul 2004 06:14:02 GMT
From: Takayuki Sakuma <takayuki@finet.fujitsu.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Subject: misc/69788: The processing result of strtoul() cannot judge whether
	it is an error.
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Jul 2004 06:20:37 -0000


>Number:         69788
>Category:       misc
>Synopsis:       The processing result of strtoul() cannot judge whether it is an error.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 30 06:20:12 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Takayuki Sakuma
>Release:        4.10-RELEASE
>Organization:
>Environment:
FreeBSD moon.finet.fujitsu.co.jp 4.10-RELEASE FreeBSD 4.10-RELEASE #0: Tue Jul  6 12:59:40 JST 2004     root@moon.finet.fujitsu.co.jp:/usr/src/sys/compile/withDVD  i386
>Description:
The processing result of strtoul() cannot judge whether it is an error when errno has already set to ERANGE before calling this function.
>How-To-Repeat:
void
main(void)
{
        unsigned long ul;
        char *p;

        ul = strtoul("4294967296", &p, 10);
        printf("ul=%lu,*p=%x,errno=%d(%s)\n", ul, *p, errno, strerror(errno));

        ul = strtoul("4294967295", &p, 10);
        printf("ul=%lu,*p=%x,errno=%d(%s)\n", ul, *p, errno, strerror(errno));

        errno=0;
        ul = strtoul("4294967295", &p, 10);
        printf("ul=%lu,*p=%x,errno=%d(%s)\n", ul, *p, errno, strerror(errno));
}

result:
ul=4294967295,*p=0,errno=34(Result too large)
ul=4294967295,*p=0,errno=34(Result too large)
ul=4294967295,*p=0,errno=22(Unknown error: 0)

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted: