Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 18 Oct 2024 21:16:49 +0200
From:      "Herbert J. Skuhra" <herbert@gojira.at>
To:        Rodrigo Osorio <rodrigo@FreeBSD.org>, jaap@NLnetLabs.nl
Cc:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   Re: git: d258c3602afd - main - dns/unbound: update to 1.22.0
Message-ID:  <87r08dfcgu.wl-herbert@gojira.at>
In-Reply-To: <87sestfcny.wl-herbert@gojira.at>
References:  <202410181320.49IDKYg5057457@gitrepo.freebsd.org> <87ttd9fs30.wl-herbert@gojira.at> <87sestfcny.wl-herbert@gojira.at>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 18 Oct 2024 21:12:33 +0200, "Herbert J. Skuhra" wrote:
> 
> On Fri, 18 Oct 2024 15:39:31 +0200, "Herbert J. Skuhra" wrote:
> > 
> > On Fri, 18 Oct 2024 15:20:34 +0200, Rodrigo Osorio wrote:
> > > 
> > > The branch main has been updated by rodrigo:
> > > 
> > > URL: https://cgit.FreeBSD.org/ports/commit/?id=d258c3602afd47841b285e0ac11de3bf09181d05
> > > 
> > > commit d258c3602afd47841b285e0ac11de3bf09181d05
> > > Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
> > > AuthorDate: 2024-10-18 13:08:53 +0000
> > > Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
> > > CommitDate: 2024-10-18 13:18:00 +0000
> > > 
> > >     dns/unbound: update to 1.22.0
> > >     
> > >     Changelog: https://nlnetlabs.nl/news/2024/Oct/17/unbound-1.22.0-released/
> > >     Full changelog: https://nlnetlabs.nl/projects/unbound/download/#unbound-1-22-0
> > >     
> > >     PR:             282172
> > >     Reported by:    Jaap Akkerhuis <jaap@NLnetLabs.nl> (maintainer)
> > > ---
> > >  dns/unbound/Makefile                                         | 12 +++++-------
> > >  dns/unbound/distinfo                                         |  6 +++---
> > >  dns/unbound/files/patch-smallapp_unbound-control-setup.sh.in | 11 -----------
> > >  dns/unbound/pkg-plist                                        |  2 +-
> > >  4 files changed, 9 insertions(+), 22 deletions(-)
> > > 
> > > diff --git a/dns/unbound/Makefile b/dns/unbound/Makefile
> > > index a32644d46e9e..56030abd2448 100644
> > > --- a/dns/unbound/Makefile
> > > +++ b/dns/unbound/Makefile
> > > @@ -1,5 +1,5 @@
> > >  PORTNAME=	unbound
> > > -DISTVERSION=	1.21.1
> > > +DISTVERSION=	1.22.0
> > >  CATEGORIES=	dns
> > >  MASTER_SITES=	https://www.nlnetlabs.nl/downloads/unbound/
> > >  
> > > @@ -10,7 +10,8 @@ WWW=		https://www.nlnetlabs.nl/projects/unbound
> > >  LICENSE=	BSD3CLAUSE
> > >  LICENSE_FILE=	${WRKSRC}/LICENSE
> > >  
> > > -LIB_DEPENDS=	libexpat.so:textproc/expat2
> > > +LIB_DEPENDS=	libexpat.so:textproc/expat2 \
> > > +		libnghttp2.so:www/libnghttp2
> > 
> > [...]
> > 
> > > -DOH_DESC=		Enable DNS-over-HTTPS support
> > 
> > [...]
> > 
> > > -DOH_LIB_DEPENDS=		libnghttp2.so:www/libnghttp2
> > > -DOH_CONFIGURE_ON=		--with-libnghttp2
> > 
> > Why? 
> > 
> > No information in PR, commit log or release notes.
> 
> Why remove option to build unbound with DOH support?
                                     ^^^^
s/with/without/
 
> And I think "--with-libnghttp2" is missing now:
> 
> diff --git a/dns/unbound/Makefile b/dns/unbound/Makefile
> index 56030abd2448..90eecde0cb23 100644
> --- a/dns/unbound/Makefile
> +++ b/dns/unbound/Makefile
> @@ -20,7 +20,8 @@ USE_RC_SUBR=  unbound
>  
>  GNU_CONFIGURE= yes
>  CONFIGURE_ARGS=        --with-libexpat=${LOCALBASE} \
> -               --with-ssl=${OPENSSLBASE}
> +               --with-ssl=${OPENSSLBASE} \
> +               --with-libnghttp2
>  TEST_TARGET=   test



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?87r08dfcgu.wl-herbert>