From owner-freebsd-multimedia@FreeBSD.ORG Sun Feb 18 17:07:21 2007 Return-Path: X-Original-To: freebsd-multimedia@freebsd.org Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7FF3F16A402 for ; Sun, 18 Feb 2007 17:07:21 +0000 (UTC) (envelope-from sbenabas@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.175]) by mx1.freebsd.org (Postfix) with ESMTP id 1BF3F13C467 for ; Sun, 18 Feb 2007 17:07:20 +0000 (UTC) (envelope-from sbenabas@gmail.com) Received: by ug-out-1314.google.com with SMTP id 71so412037ugh for ; Sun, 18 Feb 2007 09:07:20 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:mime-version:content-type; b=TqqHeezOn5XihaTKBHRIlQvj4866nNQYTGxRM21E7rQkuZzJAdR5HY3nMc/BP//O/3qltiWghwWmc247EsJlcKS7B8yvR1DvmrJ6WPr28rUNxFPis/IApVixPk5BhZIx8HDfvtnXUDBTTlkk5KubC6Ukb9gwi7hIGGRKkBTLwmo= Received: by 10.67.31.17 with SMTP id i17mr1151857ugj.1171816767994; Sun, 18 Feb 2007 08:39:27 -0800 (PST) Received: by 10.67.101.20 with HTTP; Sun, 18 Feb 2007 08:39:27 -0800 (PST) Message-ID: <32d8477c0702180839x3654f8e6i580dbc06bdeadf1c@mail.gmail.com> Date: Sun, 18 Feb 2007 11:39:27 -0500 From: "Siavosh Benabbas" To: freebsd-multimedia@freebsd.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_12741_7217158.1171816767955" Subject: ports/104427: ffmpeg-devel port's Makefile can corrupt makefile's X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Feb 2007 17:07:21 -0000 ------=_Part_12741_7217158.1171816767955 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Hello All, I filed this http://www.freebsd.org/cgi/query-pr.cgi?pr=104427 PR some time ago but it was never fixed/closed. I don't know if this is the right list but I will post it anyway. Basically the ffmpeg-devel port's Makefile has a ${REINPLACE_CMD} line ${REINPLACE_CMD} -E \ -e 's@^(CFLAGS.+)$$@\1 ${FFMPEG_CFLAGS}@' \ -e 's@^(FFLIBS|LDFLAGS)(.+)$$@\1\2 ${FFMPEG_LDFLAGS}@' This would corrupt the Makefile if a CFLAGS assignment is split over multiple lines using \ at the end of the lines. These long assignments are present in new ffmpeg sources but the port has not been updated to the last version of ffmpeg for a long time. I have also posted a patch which brings all such lines to the pattern space and fixes the problem, it is attached. Thanks, Siavosh ------=_Part_12741_7217158.1171816767955 Content-Type: text/x-patch; name=patch-1.diff; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 X-Attachment-Id: f_eybph81u Content-Disposition: attachment; filename="patch-1.diff" LS0tIE1ha2VmaWxlLm9yaWcJU2F0IE9jdCAxNCAxNTozODozOSAyMDA2CisrKyBNYWtlZmlsZQlT YXQgT2N0IDE0IDIyOjQ2OjA1IDIwMDYKQEAgLTQ3NCw2ICs0NzQsOCBAQAogCUAke0ZJTkR9ICR7 V1JLRElSfSAtdHlwZSBmIC1uYW1lICJNYWtlZmlsZSIgLXByaW50MCB8IFwKIAkJJHtYQVJHU30g LTAgLW4gNSAteCBcCiAJCQkke1JFSU5QTEFDRV9DTUR9IC1FIFwKKwkJCS1lICc6YWdhaW4nIC1l ICcvLipcXCQkL04nIC1lICdzLyguKilcXCQkL1wxXFwvZycgXAorCQkJLWUgJ3QgYWdhaW4nIFwK IAkJCS1lICdzQF4oQ0ZMQUdTLispJCRAXDEgJHtGRk1QRUdfQ0ZMQUdTfUAnIFwKIAkJCS1lICdz QF4oRkZMSUJTfExERkxBR1MpKC4rKSQkQFwxXDIgJHtGRk1QRUdfTERGTEFHU31AJwogIyBmaXgg eDI2NCBtYXRoLCB1c2UgY29ycmVjdCBsb2cgYmFzZSAyIGZyb20gbWF0aCgzKQoK ------=_Part_12741_7217158.1171816767955--