From owner-freebsd-net@freebsd.org Fri Jun 22 18:20:17 2018 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3D52310236E6 for ; Fri, 22 Jun 2018 18:20:17 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from forward102o.mail.yandex.net (forward102o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::602]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "forwards.mail.yandex.net", Issuer "Yandex CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A184E7ACA2; Fri, 22 Jun 2018 18:20:16 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from mxback4j.mail.yandex.net (mxback4j.mail.yandex.net [IPv6:2a02:6b8:0:1619::10d]) by forward102o.mail.yandex.net (Yandex) with ESMTP id 89D4D5A013BB; Fri, 22 Jun 2018 21:20:07 +0300 (MSK) Received: from smtp4j.mail.yandex.net (smtp4j.mail.yandex.net [2a02:6b8:0:1619::15:6]) by mxback4j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 3NCm4E9maV-K7e4ej2M; Fri, 22 Jun 2018 21:20:07 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1529691607; bh=kPUyR8Ti3Q1yBK+rJZ6DMjv+qv8DdhrTcybWUNILWrQ=; h=Subject:To:References:Cc:From:Message-ID:Date:In-Reply-To; b=XBv2+65FooLKwIttRMbUaEWzKon6+hOLPC7En1Z453rSzjWx8ZQr7S0Cu6NmPdzoT NT/swKFN6A5HBWT+wKJuJZ71SsJI4sJeT2dWQhXdCInYDIv7VjPTtG55JJ6sFjUJVC pXnAX2uDsht/7qwGOYW6ZSy6MAe6+fQ+MojwPm+Y= Received: by smtp4j.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id LzrOOys0PP-K6C0D6Qc; Fri, 22 Jun 2018 21:20:06 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1529691606; bh=kPUyR8Ti3Q1yBK+rJZ6DMjv+qv8DdhrTcybWUNILWrQ=; h=Subject:To:References:Cc:From:Message-ID:Date:In-Reply-To; b=GgAec7wu4myh5KS1G0cb4a8LXUx8KjncGas3FXTKZpxiFEEPsECTT07DW0hycmdf2 F0U6ebZ2HLdowdHeqdsnIhdqrphM648peQrWWhONSICE5nd49/0qtjQBY0h6V5vlVC FJAZ8/GmoEXgsYUJw0qvQWd/sE4JzeLUuSqKATm4= Authentication-Results: smtp4j.mail.yandex.net; dkim=pass header.i=@yandex.ru Subject: Re: [PATCH]: The 6to4 stf0 interface flapping in/out of tentative in FreeBSD 11 To: freebsd-net@freebsd.org, Viktor Dukhovni References: <20171106042248.GL3322@mournblade.imrryr.org> <20180622163812.GA17559@mournblade.imrryr.org> <8fe71247-a9a4-e3cb-3e4a-03852307f080@yandex.ru> Cc: "Bjoern A. Zeeb" , Mark Johnston From: "Andrey V. Elsukov" Openpgp: id=E6591E1B41DA1516F0C9BC0001C5EA0410C8A17A Autocrypt: addr=bu7cher@yandex.ru; prefer-encrypt=mutual; keydata= xsBNBEwBF1kBCADB9sXFhBEUy8qQ4X63Y8eBatYMHGEFWN9ypS5lI3RE6qQW2EYbxNk7qUC5 21YIIS1mMFVBEfvR7J9uc7yaYgFCEb6Sce1RSO4ULN2mRKGHP3/Sl0ijZEjWHV91hY1YTHEF ZW/0GYinDf56sYpDDehaBF5wkWIo1+QK5nmj3vl0DIDCMNd7QEiWpyLVwECgLX2eOAXByT8B bCqVhJGcG6iFP7/B9Ll6uX5gb8thM9LM+ibwErDBVDGiOgvfxqidab7fdkh893IBCXa82H9N CNwnEtcgzh+BSKK5BgvPohFMgRwjti37TSxwLu63QejRGbZWSz3OK3jMOoF63tCgn7FvABEB AAHNIkFuZHJleSBWLiBFbHN1a292IDxhZUBmcmVlYnNkLm9yZz7CwHsEEwECACUCGwMGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheABQJMB/ruAhkBAAoJEAHF6gQQyKF6MLwH/3Ri/TZl9uo0 SepYWXOnxL6EaDVXDA+dLb1eLKC4PRBBjX29ttQ0KaWapiE6y5/AfzOPmRtHLrHYHjd/aiHX GMLHcYRXD+5GvdkK8iMALrZ28X0JXyuuZa8rAxWIWmCbYHNSBy2unqWgTI04Erodk90IALgM 9JeHN9sFqTM6zalrMnTzlcmel4kcjT3lyYw3vOKgoYLtsLhKZSbJoVVVlvRlGBpHFJI5AoYJ SyfXoN0rcX6k9X7Isp2K50YjqxV4v78xluh1puhwZyC0p8IShPrmrp9Oy9JkMX90o6UAXdGU KfdExJuGJfUZOFBTtNIMNIAKfMTjhpRhxONIr0emxxDOwE0ETAEXWQEIAJ2p6l9LBoqdH/0J PEFDY2t2gTvAuzz+8zs3R03dFuHcNbOwjvWCG0aOmVpAzkRa8egn5JB4sZaFUtKPYJEQ1Iu+ LUBwgvtXf4vWpzC67zs2dDuiW4LamH5p6xkTD61aHR7mCB3bg2TUjrDWn2Jt44cvoYxj3dz4 S49U1rc9ZPgD5axCNv45j72tggWlZvpefThP7xT1OlNTUqye2gAwQravXpZkl5JG4eOqJVIU X316iE3qso0iXRUtO7OseBf0PiVmk+wCahdreHOeOxK5jMhYkPKVn7z1sZiB7W2H2TojbmcK HZC22sz7Z/H36Lhg1+/RCnGzdEcjGc8oFHXHCxUAEQEAAcLAXwQYAQIACQUCTAEXWQIbDAAK CRABxeoEEMihegkYCAC3ivGYNe2taNm/4Nx5GPdzuaAJGKWksV+w9mo7dQvU+NmI2az5w8vw 98OmX7G0OV9snxMW+6cyNqBrVFTu33VVNzz9pnqNCHxGvj5dL5ltP160JV2zw2bUwJBYsgYQ WfyJJIM7l3gv5ZS3DGqaGIm9gOK1ANxfrR5PgPzvI9VxDhlr2juEVMZYAqPLEJe+SSxbwLoz BcFCNdDAyXcaAzXsx/E02YWm1hIWNRxanAe7Vlg7OL+gvLpdtrYCMg28PNqKNyrQ87LQ49O9 50IIZDOtNFeR0FGucjcLPdS9PiEqCoH7/waJxWp6ydJ+g4OYRBYNM0EmMgy1N85JJrV1mi5i Message-ID: <964bd37c-fe7b-1a99-6c5e-9a367cfad29f@yandex.ru> Date: Fri, 22 Jun 2018 21:17:03 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uBTppnhad4PIkNb5seqRMVgoIguy7yl5z" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jun 2018 18:20:17 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uBTppnhad4PIkNb5seqRMVgoIguy7yl5z Content-Type: multipart/mixed; boundary="hdiAmpdhIcQUpMhkTRXgS429NQUNeScFI"; protected-headers="v1" From: "Andrey V. Elsukov" To: freebsd-net@freebsd.org, Viktor Dukhovni Cc: "Bjoern A. Zeeb" , Mark Johnston Message-ID: <964bd37c-fe7b-1a99-6c5e-9a367cfad29f@yandex.ru> Subject: Re: [PATCH]: The 6to4 stf0 interface flapping in/out of tentative in FreeBSD 11 References: <20171106042248.GL3322@mournblade.imrryr.org> <20180622163812.GA17559@mournblade.imrryr.org> <8fe71247-a9a4-e3cb-3e4a-03852307f080@yandex.ru> In-Reply-To: --hdiAmpdhIcQUpMhkTRXgS429NQUNeScFI Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 22.06.2018 21:08, Viktor Dukhovni wrote: >> Your change looks reasonable due to IPv6 DAD procedure does check for >> presence of IFF_DRV_RUNNING flag. But actually it seems the right >> solution should be disabling DAD for if_stf(4) interface. >> IPv6 DAD requires that given interface should be multicast capable, bu= t >> for if_stf(4) it is not true. >> Will it help if you use `ifconfig stf0 inet6 no_dad` before assigning >> IPv6 address? >=20 > stf_up() in /etc/rc.d/stf has: >=20 > ifconfig stf0 create >/dev/null 2>&1 > ifconfig stf0 inet6 2002:${ipv4_in_hexformat}:${stf_int= erface_ipv6_slaid:-0}:${stf_interface_ipv6_ifid} \ > prefixlen ${stf_prefixlen} >=20 > Are you suggesting to add the: >=20 > ifconfig stf0 inet6 no_data Yes, but "no_dad", not "no_data". > right under "ifconfig stf0 create"? I'd have to find a convenient time= to > reboot to the stock kernel, so this will take O(12 hours) before I can = re-test. >=20 > Perhaps the fix should be belt-and-suspenders? Both set IFF_DRV_RUNNIN= G > and disable DAD automatically for lack of multicast support? Setting > the flag bit might avoid other future issues. Avoiding needless DAD > polling sounds sensible. We have already one tweak for if_stf(4) in in6_ifattach(), that disables automatic LLA creation. I think we can also add disabling DAD there. Something like: Index: in6_ifattach.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- in6_ifattach.c (revision 335361) +++ in6_ifattach.c (working copy) @@ -683,6 +683,7 @@ in6_ifattach(struct ifnet *ifp, struct ifnet *alti * it is rather harmful to have one. */ ND_IFINFO(ifp)->flags &=3D ~ND6_IFF_AUTO_LINKLOCAL; + ND_IFINFO(ifp)->flags |=3D ND6_IFF_NO_DAD; break; default: break; --=20 WBR, Andrey V. Elsukov --hdiAmpdhIcQUpMhkTRXgS429NQUNeScFI-- --uBTppnhad4PIkNb5seqRMVgoIguy7yl5z Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAlstPR8ACgkQAcXqBBDI oXo1TAf5AUsEd/HggPseGZQu12IdIYRaEFuis1jct0yY+j3/gitlRzLmk4jsMJ62 DqdxM1iE0HLC3CmiTBNM4lml7LW7OkJvpA3OFOSIGWMdR0UFx47fo6fXsEwqPqH/ pwe2KHXJWzbfacC3myPxJ4E4ogA+s1Uasqelcck3GjXDMcLzq8UcYkOMdF1meCdK vKvo6r5u0LOJZh3xINyPzewqrw5Pd1ek4TRaD7n7Tm5nyIFc9Qip18u8j7w6ERyk DPz74trV3XtyDke7lX53N6Gwhyj9CiSfQKvpGVbOc019gFXTG8Ix6M1qSX/B3D6E UISTTG7b5ZtmkXm+cLnFmqK8c03E0Q== =/E0A -----END PGP SIGNATURE----- --uBTppnhad4PIkNb5seqRMVgoIguy7yl5z--