From owner-freebsd-stable@FreeBSD.ORG  Sat Aug  4 00:18:47 2007
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 595B616A417;
	Sat,  4 Aug 2007 00:18:47 +0000 (UTC)
	(envelope-from pieter@degoeje.nl)
Received: from smtp.utwente.nl (unknown
	[IPv6:2001:610:1908:1000:204:23ff:feb5:7e66])
	by mx1.freebsd.org (Postfix) with ESMTP id 70CA813C46C;
	Sat,  4 Aug 2007 00:18:46 +0000 (UTC)
	(envelope-from pieter@degoeje.nl)
Received: from lux.student.utwente.nl (lux.student.utwente.nl [130.89.170.81])
	by smtp.utwente.nl (8.12.10/SuSE Linux 0.7) with ESMTP id
	l740ISj1018662; Sat, 4 Aug 2007 02:18:30 +0200
From: Pieter de Goeje <pieter@degoeje.nl>
To: "Sean C. Farley" <scf@freebsd.org>
Date: Sat, 4 Aug 2007 02:18:27 +0200
User-Agent: KMail/1.9.7
References: <20070802114827.U26646@pat.io.com>
	<200708040129.58761.pieter@degoeje.nl>
	<20070803184340.L84415@thor.farley.org>
In-Reply-To: <20070803184340.L84415@thor.farley.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200708040218.28169.pieter@degoeje.nl>
X-UTwente-MailScanner-Information: Scanned by MailScanner. Contact
	helpdesk@ITBE.utwente.nl for more information.
X-UTwente-MailScanner: Found to be clean
X-UTwente-MailScanner-From: pieter@degoeje.nl
X-Spam-Status: No
Cc: Xin LI <delphij@delphij.net>, freebsd-stable@freebsd.org,
	Ted Hatfield <ted@pat.io.com>
Subject: Re: Bug in less version 406.
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 04 Aug 2007 00:18:47 -0000

On Saturday 04 August 2007, Sean C. Farley wrote:
> On Sat, 4 Aug 2007, Pieter de Goeje wrote:
>
> *snip*
>
> > There's also another regression in less: it doesn't automatically
> > repaint the screen anymore when you resize the terminal.
>
> I have already reported that regression to Mark Nudelman.  He is looking
> into an appropriate fix since this regression was introduced when fixing
> another bug.
>
> Sean
Hmm I wonder what that other bug might have been...
If I look at signal.c I see two signal handlers for things related to window 
changes. One for SIGWINCH and one for SIGWIND. The "if(reading) intread();" 
statement was removed from the SIGWINCH handler. If removing that statement 
fixed the other bug why wasn't it removed from SIGWIND's handler? Does 
SIGWIND have different semantics?

Anyway, re-adding "if(reading) intread();" to signal.c:96 makes it work again, 
but I wonder what I broke by doing that.

Regards,
Pieter de Goeje