Date: Sun, 6 Jun 2010 10:50:12 GMT From: Anonymous <swell.k@gmail.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/147546: Update Port: editors/emacs-devel to a snapshot of 24.x Message-ID: <201006061050.o56AoCN6098699@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/147546; it has been noted by GNATS.
From: Anonymous <swell.k@gmail.com>
To: wahjava@gmail.com (Ashish SHUKLA)
Cc: bug-followup@FreeBSD.org, keramida@FreeBSD.org
Subject: Re: ports/147546: Update Port: editors/emacs-devel to a snapshot of 24.x
Date: Sun, 06 Jun 2010 10:42:25 +0000
wahjava@gmail.com (Ashish SHUKLA) writes:
> Anonymous writes:
>> Ashish SHUKLA <wahjava@gmail.com> writes:
>
>>> Acknowledgements:
>>> - Anonymous for the compilation fix on 6.x and 9.x when DBUS is enabled.
>
> /Anonymous/d
>
>> [...]
>>> +DBUS_PTHREAD_LIBS= ${CC} -dumpspecs | ${GREP} -m 1 pthread: | ${SED} -e 's|^.*%{\!pg: %{pthread:||' -e 's|}.*$$||' || ${TRUE}
>>> +
>> [...]
>>> +post-configure:
>>> + @${REINPLACE_CMD} -e "s/^\(DBUS_LIBS.*\)-pthread\(.*\)$$/\1$$(${DBUS_PTHREAD_LIBS})\2/" ${WRKSRC}/src/Makefile
>>> +
>
>> Remove my credit. Your version is complex, uses backreferences (slow)
>> and assumes `$$/' is not interpreted by sh(1) as variable. Besides, it's
>> now harder to check value
>
>> $ make -V DBUS_PTHREAD_LIBS
>
> Yes, and also it makes it now harder to invoke a cc/grep/sed/sh during INDEX
> generation.
DBUS_PTHREAD_LIBS is defined after bsd.port.options.mk. At that point
SED/GREP/TRUE are already defined. And `make describe' as well as `make index'
don't produce errors. The only issue here is performance of `make describe'.
And tools like portupgrade use fetchindex target because it's faster.
So, I'm against sacrificing simplicity for a target that's rarely used.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006061050.o56AoCN6098699>