From owner-freebsd-gnome@freebsd.org Tue Feb 14 16:34:19 2017 Return-Path: Delivered-To: freebsd-gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 812E6CDF5C6 for ; Tue, 14 Feb 2017 16:34:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 6A383125B for ; Tue, 14 Feb 2017 16:34:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 6983DCDF5C5; Tue, 14 Feb 2017 16:34:19 +0000 (UTC) Delivered-To: gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 69271CDF5C4 for ; Tue, 14 Feb 2017 16:34:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 584C3125A for ; Tue, 14 Feb 2017 16:34:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v1EGYJY6076115 for ; Tue, 14 Feb 2017 16:34:19 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 211201] print/freetype2: update to 2.7, add V40 code Date: Tue, 14 Feb 2017 16:34:19 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: lightside@gmx.com X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kwm@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? exp-run? merge-quarterly? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Feb 2017 16:34:19 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211201 --- Comment #80 from lightside --- The compiler's warning in comment #79 may create impression, that possible = to define TT_CONFIG_OPTION_SUBPIXEL_HINTING to 0, instead of comment/undefine = it, in case of V38=3Doff and V40=3Doff.=20 I created some test.c program to test this: -8<-- #include #ifndef CHECK #if defined(TT_CONFIG_OPTION_SUBPIXEL_HINTING) && (TT_CONFIG_OPTION_SUBPIXEL_HINTING & 1) #define TT_SUPPORT_SUBPIXEL_HINTING_INFINALITY #endif #if defined(TT_CONFIG_OPTION_SUBPIXEL_HINTING) && (TT_CONFIG_OPTION_SUBPIXEL_HINTING & 2) #define TT_SUPPORT_SUBPIXEL_HINTING_MINIMAL #endif #else #if TT_CONFIG_OPTION_SUBPIXEL_HINTING & 1 #define TT_SUPPORT_SUBPIXEL_HINTING_INFINALITY #endif #if TT_CONFIG_OPTION_SUBPIXEL_HINTING & 2 #define TT_SUPPORT_SUBPIXEL_HINTING_MINIMAL #endif #endif int main() { printf("default\n"); #ifdef TT_SUPPORT_SUBPIXEL_HINTING_INFINALITY printf("infinality\n"); #endif #ifdef TT_SUPPORT_SUBPIXEL_HINTING_MINIMAL printf("minimal\n"); #endif return 0; } -->8- with following results: -8<-- % cc -o test test.c && ./test default % cc -DTT_CONFIG_OPTION_SUBPIXEL_HINTING=3D0 -o test test.c && ./test default % cc -DTT_CONFIG_OPTION_SUBPIXEL_HINTING=3D1 -o test test.c && ./test default infinality % cc -DTT_CONFIG_OPTION_SUBPIXEL_HINTING=3D2 -o test test.c && ./test default minimal % cc -DTT_CONFIG_OPTION_SUBPIXEL_HINTING=3D3 -o test test.c && ./test default infinality minimal % cc -DCHECK -Wundef -o test test.c && ./test test.c:12:5: warning: 'TT_CONFIG_OPTION_SUBPIXEL_HINTING' is not defined, evaluates to 0 [-Wundef] #if TT_CONFIG_OPTION_SUBPIXEL_HINTING & 1 ^ test.c:16:5: warning: 'TT_CONFIG_OPTION_SUBPIXEL_HINTING' is not defined, evaluates to 0 [-Wundef] #if TT_CONFIG_OPTION_SUBPIXEL_HINTING & 2 ^ 2 warnings generated. default -->8- But in case of freetype2 source code, there is some check for defined TT_CONFIG_OPTION_SUBPIXEL_HINTING: http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/src/truetype/t= tgload.c?h=3DVER-2-7-1#n1355 -8<-- #ifdef TT_CONFIG_OPTION_SUBPIXEL_HINTING TT_Driver driver =3D (TT_Driver)FT_FACE_DRIVER( loader->face ); #endif -->8- So, defining TT_CONFIG_OPTION_SUBPIXEL_HINTING to 0 may create different result(s). Moreover, the freetype2's developer(s) commented/undefined TT_CONFIG_OPTION_SUBPIXEL_HINTING for 2.6.5 version: http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/include/freety= pe/config/ftoption.h?h=3DVER-2-6-5#n633 http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/include/freety= pe/config/ftoption.h?h=3DVER-2-6-5#n845 in preparation for 2.7.x series: http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/docs/CHANGES?h= =3DVER-2-6-5#n10 This is why TT_CONFIG_OPTION_SUBPIXEL_HINTING was commented/undefined for V38=3Doff and V40=3Doff case. --=20 You are receiving this mail because: You are on the CC list for the bug.=