From owner-p4-projects@FreeBSD.ORG  Fri May 21 00:00:31 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id C83C5106571E; Fri, 21 May 2010 00:00:30 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7E52E106567C
	for <perforce@freebsd.org>; Fri, 21 May 2010 00:00:30 +0000 (UTC)
	(envelope-from iprebeg@freebsd.org)
Received: from repoman.freebsd.org (unknown [IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 5B8338FC1A
	for <perforce@freebsd.org>; Fri, 21 May 2010 00:00:30 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o4L00UQp013987
	for <perforce@freebsd.org>; Fri, 21 May 2010 00:00:30 GMT
	(envelope-from iprebeg@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o4L00Ufu013985
	for perforce@freebsd.org; Fri, 21 May 2010 00:00:30 GMT
	(envelope-from iprebeg@freebsd.org)
Date: Fri, 21 May 2010 00:00:30 GMT
Message-Id: <201005210000.o4L00Ufu013985@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	iprebeg@freebsd.org using -f
From: Ivor Prebeg <iprebeg@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 178574 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 May 2010 00:00:31 -0000

http://p4web.freebsd.org/@@178574?ac=10

Change 178574 by iprebeg@iprebeg_zeus on 2010/05/21 00:00:24

	Dirty hack, needs beautifing, leaving that for afterhours... fixes crash on X_ip_mrouter_done()

Affected files ...

.. //depot/projects/vimage/src/sys/netinet/ip_mroute.c#39 edit
.. //depot/projects/vimage/src/sys/netinet6/ip6_mroute.c#33 edit

Differences ...

==== //depot/projects/vimage/src/sys/netinet/ip_mroute.c#39 (text+ko) ====

@@ -608,6 +608,7 @@
 ip_mrouter_reset(void)
 {
 
+    /*
     V_pim_assert_enabled = 0;
     V_mrt_api_config = 0;
 
@@ -617,6 +618,7 @@
     bzero(V_bw_meter_timers, sizeof(V_bw_meter_timers));
     callout_init(&V_bw_upcalls_ch, CALLOUT_MPSAFE);
     callout_init(&V_bw_meter_ch, CALLOUT_MPSAFE);
+    */
 }
 
 static void
@@ -2829,6 +2831,18 @@
 {
 
 	MALLOC(V_nexpire, u_char *, mfchashsize, M_MRTABLE, M_WAITOK|M_ZERO);
+
+    /* from ip_mrouter_reset */
+    V_pim_assert_enabled = 0;
+    V_mrt_api_config = 0;
+
+    callout_init(&V_expire_upcalls_ch, CALLOUT_MPSAFE);
+
+    V_bw_upcalls_n = 0;
+    bzero(V_bw_meter_timers, sizeof(V_bw_meter_timers));
+    callout_init(&V_bw_upcalls_ch, CALLOUT_MPSAFE);
+    callout_init(&V_bw_meter_ch, CALLOUT_MPSAFE);
+    /* from ip_mrouter_reset */
 }
 
 VNET_SYSINIT(vnet_mroute_init, SI_SUB_PSEUDO, SI_ORDER_MIDDLE, vnet_mroute_init,
@@ -2838,7 +2852,9 @@
 vnet_mroute_uninit(const void *unused __unused)
 {
 
+#ifndef VIMAGE
 	X_ip_mrouter_done();
+#endif
 	FREE(V_nexpire, M_MRTABLE);
 	V_nexpire = NULL;
 }

==== //depot/projects/vimage/src/sys/netinet6/ip6_mroute.c#33 (text+ko) ====

@@ -81,13 +81,6 @@
 #include <sys/cdefs.h>
 __FBSDID("$FreeBSD: src/sys/netinet6/ip6_mroute.c,v 1.64 2010/04/29 11:52:42 bz Exp $");
 
-#define VIMAGE
-#define DIAGNOSTIC
-//#define MRT6DEBUG
-//#define MRT6_OINIT
-#define PIM6_CHECKSUM
-#define UPCALL_TIMING
-
 //#include "opt_inet.h"
 #include "opt_inet6.h"