From owner-cvs-src@FreeBSD.ORG Tue Aug 10 14:49:14 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8680E16A4D0 for ; Tue, 10 Aug 2004 14:49:14 +0000 (GMT) Received: from mail4.speakeasy.net (mail4.speakeasy.net [216.254.0.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4196143D45 for ; Tue, 10 Aug 2004 14:49:14 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 7464 invoked from network); 10 Aug 2004 14:49:13 -0000 Received: from gate.funkthat.com (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail4.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 10 Aug 2004 14:49:13 -0000 Received: from hydrogen.funkthat.com (pyjsba@localhost.funkthat.com [127.0.0.1])i7AEnDuU078139; Tue, 10 Aug 2004 07:49:13 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id i7AEnDlu078138; Tue, 10 Aug 2004 07:49:13 -0700 (PDT) Date: Tue, 10 Aug 2004 07:49:13 -0700 From: John-Mark Gurney To: Ruslan Ermilov Message-ID: <20040810144913.GO991@funkthat.com> References: <200408090645.i796jLUo046034@repoman.freebsd.org> <20040810122307.GA18408@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040810122307.GA18408@ip.net.ua> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys mdioctl.h src/sys/modules/md Makefile src/sbin/mdconfig mdconfig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Aug 2004 14:49:14 -0000 Ruslan Ermilov wrote this message on Tue, Aug 10, 2004 at 15:23 +0300: > On Mon, Aug 09, 2004 at 06:45:21AM +0000, John-Mark Gurney wrote: > > jmg 2004-08-09 06:45:21 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/sys mdioctl.h > > sys/modules/md Makefile > > sbin/mdconfig mdconfig.c > > Log: > > change the name of the md module, to g_md, introduce a define with the > > name MD_MODNAME, and make mdconfig use this new define... > > > > Revision Changes Path > > 1.33 +1 -1 src/sbin/mdconfig/mdconfig.c > > 1.13 +1 -1 src/sys/modules/md/Makefile > > 1.16 +1 -0 src/sys/sys/mdioctl.h > > > Why the change in the first place? so that mdconfig does not try to load the md kernel module twice, and cause your machine to panic. With a recent commit of phk's to md that converts it to geom, he removed the previous DECLARE_MODULE w/ the name of md, and so the md module was no longer implementing the md module, only the g_md module. On my box that is using mfs, mdconfig would then try to load the md module a second time causing geom to panic. Sorry, I should of included some of this information in the commit message. I then realized that since md is now a full on geom module, it should be renamed to geom_md like all the other geom modules... I still need to ask cvs@ to repo copy the module Makefiles into modules/geom/md... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."