From owner-cvs-all@FreeBSD.ORG Tue Jun 9 18:34:39 2009 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1604E1065673 for ; Tue, 9 Jun 2009 18:34:39 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 930088FC18 for ; Tue, 9 Jun 2009 18:34:38 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 20157 invoked by uid 399); 9 Jun 2009 18:34:37 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 9 Jun 2009 18:34:37 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4A2EAB3B.6040205@FreeBSD.org> Date: Tue, 09 Jun 2009 11:34:35 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.21 (X11/20090423) MIME-Version: 1.0 To: Wesley Shields References: <200906091346.n59Dk3vj093458@repoman.freebsd.org> <4A2EA0A1.6010607@FreeBSD.org> <20090609180020.GA40405@atarininja.org> In-Reply-To: <20090609180020.GA40405@atarininja.org> X-Enigmail-Version: 0.95.7 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports UPDATING X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2009 18:34:39 -0000 Wesley Shields wrote: > The problem was not with portmaster, That's always good news. :) > but was with the reliance on > pkg_which. The attached patch should fit it. I currently have sent it > to itetcu and miwi for review. The biggest downside is that pkg_info can > not take multiple arguments on the command line like pkg_which does, so > we have to use xargs -L 1, which makes things slow compared to using > pkg_which. Have you benchmarked that? I would imagine (although I don't know for sure) that pkg_which is just calling whatever method it uses to get the answer once each time for each command line argument, which would mean that they are basically equivalent. It seems that the current solution is needlessly complicated (although I haven't benchmarked either). What would be wrong with something like: for file in `find -type f`; do pkg_info -qW $file done | sort -u Doug -- This .signature sanitized for your protection