From owner-svn-ports-all@freebsd.org Mon Jul 16 09:45:35 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 67B731048348; Mon, 16 Jul 2018 09:45:35 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1604F88FB9; Mon, 16 Jul 2018 09:45:35 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from ogg.in.absolight.net (ogg.in.absolight.net [IPv6:2a01:678:ab:50::42:42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4B42897AC; Mon, 16 Jul 2018 09:45:34 +0000 (UTC) (envelope-from mat@FreeBSD.org) Date: Mon, 16 Jul 2018 11:45:30 +0200 From: Mathieu Arnold To: Gerald Pfeifer Cc: Dmitry Marakasov , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r470444 - head/lang/gcc-ecj45 Message-ID: <20180716094530.k6ls4yddh2nmlivd@ogg.in.absolight.net> References: <201805200904.w4K94BAh007929@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vxfcplee3ydndkos" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180622 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2018 09:45:35 -0000 --vxfcplee3ydndkos Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 14, 2018 at 10:39:11PM +0200, Gerald Pfeifer wrote: > On Sun, 20 May 2018, Dmitry Marakasov wrote: > > Author: amdmi3 > > Date: Sun May 20 09:04:10 2018 > > New Revision: 470444 > > URL: https://svnweb.freebsd.org/changeset/ports/470444 > >=20 > > Log: > > - Add LICENSE > > - Cosmetic fixes > > - Add NO_ARCH > > =20 > > Approved by: portmgr blanket >=20 > I'm not really sure "cosmetic fixes" are covered by portmgr > blanket, especially where something is a style issue. >=20 > For example... >=20 > > Modified: head/lang/gcc-ecj45/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > -EXTRACT_SUFX=3D > > -EXTRACT_ONLY=3D > > +EXTRACT_SUFX=3D # empty > > +EXTRACT_ONLY=3D # empty >=20 > ...I preferred the original version of that and do not see this > as a real improvement. There is some kind of, mmmm, style police that, I think, believe variables must have a value, so when a variable is empty, they see it as their fight to add "# empty" comments everywhere. Never understood it myself. --=20 Mathieu Arnold --vxfcplee3ydndkos Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAltMaTpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkjXFRAAlKkOogVLqHTTNA3jJS39ERdE3zOvMlh+Pg+emhSXwHp8rQ4V+mufXlaS mtorRl5FIQA7lbUshQoFnZxocqEHmSWiUH/otTl0EDNt14TjmHZbnvor1FCpj+RM e5Hvxgmq7QRrA77mR242fjCuw3VQmdKg6GqPLs4IEvIy/jZivUPKE8+XtmHSVgC9 giu6AheXkuEqmfA/92Bg6y033t1J9cY+thu8apxlAxuY9J/zub6Q6F+ccDXDbYCE nJflsf0fnIoAp58MBDdGmJX37G86sxPYo+Cz4zun8EK2RM2lxpVxyslZngUndxI1 1mmoq6BleZHVv3Ijg0foZReBLm/1ZaSzakMVaoEmPB7CjQo51mvHCOdlt8gu8izG bgRn80lF+HAd7hPJi15bd5K7mC2pULaYP6QJJXfEW2W0UyhIzX2OWHzz+FY7U/M4 wPTTqDIoAvZZppsp2oJZ4bnBkk1iFydpkgSV3H+GR85MYnA9Z65azAlp1NJUVFHg Cdkjipaau1si3YtnyoLbTYPLQGl+cSpynoh1D/AdhjumNJnz66phygxuhmN/tasc ao32EQUksyz8MJmLLIe1vtMtJeWiwMczTAL52RTXgFQnhsQ0BhcOocVVcyN6dvtU JryASutoFDO7PVxlLvJxX5YuW8WEndtOTDGGn4CF0/KDcCbG5RU= =EaTi -----END PGP SIGNATURE----- --vxfcplee3ydndkos--