From owner-cvs-all@FreeBSD.ORG Mon Mar 15 09:07:20 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 551FB16A4CE; Mon, 15 Mar 2004 09:07:20 -0800 (PST) Received: from cs.rice.edu (cs.rice.edu [128.42.1.30]) by mx1.FreeBSD.org (Postfix) with ESMTP id 26BD543D2F; Mon, 15 Mar 2004 09:07:20 -0800 (PST) (envelope-from alc@cs.rice.edu) Received: from localhost (calypso.cs.rice.edu [128.42.1.127]) by cs.rice.edu (Postfix) with ESMTP id B5CC14AB64; Mon, 15 Mar 2004 11:07:16 -0600 (CST) Received: from cs.rice.edu ([128.42.1.30]) by localhost (calypso.cs.rice.edu [128.42.1.127]) (amavisd-new, port 10024) with LMTP id 13437-01-63; Mon, 15 Mar 2004 11:07:16 -0600 (CST) Received: by cs.rice.edu (Postfix, from userid 19572) id 665764AB5A; Mon, 15 Mar 2004 11:07:15 -0600 (CST) Date: Mon, 15 Mar 2004 11:07:15 -0600 From: Alan Cox To: Don Lewis Message-ID: <20040315170715.GM21071@cs.rice.edu> References: <200403150636.i2F6atAN066155@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200403150636.i2F6atAN066155@repoman.freebsd.org> User-Agent: Mutt/1.3.28i X-Virus-Scanned: by amavis-20030616-p7 at cs.rice.edu cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_mmap.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2004 17:07:20 -0000 On Sun, Mar 14, 2004 at 10:36:55PM -0800, Don Lewis wrote: > truckman 2004/03/14 22:36:55 PST > > FreeBSD src repository > > Modified files: > sys/vm vm_mmap.c > Log: > Remove redundant suser() check. > > Revision Changes Path > 1.183 +0 -4 src/sys/vm/vm_mmap.c I think the same would apply to munlockall(2). In general, I would encourage you to take a look at mlockall(2) and munlockall(2) with an eye toward reducing the stylistic differences in how mlock(2) and munlock(2) versus mlockall(2) and munlockall(2) are written. Regards, Alan