From owner-freebsd-bugs@FreeBSD.ORG  Wed Oct  6 14:30:26 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AAB9A16A4D1
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  6 Oct 2004 14:30:26 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 828BE43D5A
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  6 Oct 2004 14:30:26 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i96EUQpq061561
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 6 Oct 2004 14:30:26 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i96EUQ4D061559;
	Wed, 6 Oct 2004 14:30:26 GMT
	(envelope-from gnats)
Resent-Date: Wed, 6 Oct 2004 14:30:26 GMT
Resent-Message-Id: <200410061430.i96EUQ4D061559@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Momtchil Momtchev <momtchil.momtchev@netasq.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C238716A4D0
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed,  6 Oct 2004 14:21:09 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A21AD43D46
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed,  6 Oct 2004 14:21:09 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i96EL98X038832
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 6 Oct 2004 14:21:09 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.11/8.12.11/Submit) id i96EL9g3038831;
	Wed, 6 Oct 2004 14:21:09 GMT
	(envelope-from nobody)
Message-Id: <200410061421.i96EL9g3038831@www.freebsd.org>
Date: Wed, 6 Oct 2004 14:21:09 GMT
From: Momtchil Momtchev <momtchil.momtchev@netasq.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Subject: misc/72385: memory leak in libfetch
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Oct 2004 14:30:26 -0000


>Number:         72385
>Category:       misc
>Synopsis:       memory leak in libfetch
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 06 14:30:25 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Momtchil Momtchev
>Release:        up to 5.3 BETA 6
>Organization:
NETASQ
>Environment:
FreeBSD garga.netasq.int 5.3-BETA5 FreeBSD 5.3-BETA5
>Description:
fetchGet() is leaking on HTTP 404 File Not Found
>How-To-Repeat:
fetchGet() is leaking on HTTP 404 File Not Found
>Fix:
                fetchFreeURL(url);
        if (purl)
                fetchFreeURL(purl);
-       if (conn != NULL)
-               _fetch_close(conn);
+       if (conn != NULL) {
+               if (conn->buf)
+                       free(conn->buf);
+               _fetch_close(conn);
+       }
>Release-Note:
>Audit-Trail:
>Unformatted: