From owner-cvs-all Tue Sep 19 23:17:50 2000 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (tun.AwfulHak.org [194.242.139.173]) by hub.freebsd.org (Postfix) with ESMTP id B974437B42C; Tue, 19 Sep 2000 23:17:44 -0700 (PDT) Received: from hak.lan.Awfulhak.org (root@hak.lan.awfulhak.org [172.16.0.12]) by Awfulhak.org (8.11.0/8.11.0) with ESMTP id e8K6Hvv57954; Wed, 20 Sep 2000 07:17:57 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.0/8.11.0) with ESMTP id e8K6GPs13592; Wed, 20 Sep 2000 07:16:25 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200009200616.e8K6GPs13592@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.1.1 10/15/1999 To: Poul-Henning Kamp Cc: Brian Somers , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@Awfulhak.org Subject: Re: cvs commit: src/lib/libc/stdlib malloc.c setenv.c In-Reply-To: Message from Poul-Henning Kamp of "Wed, 20 Sep 2000 07:42:40 +0200." <94347.969428560@critter> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 20 Sep 2000 07:16:25 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > In message <200009200305.UAA32271@freefall.freebsd.org>, Brian Somers writes: > >brian 2000/09/19 20:05:38 PDT > > > > Modified files: > > lib/libc/stdlib malloc.c setenv.c > > Log: > > Only realloc() environ if we're sure that we know where it came from. > > > > The recent problems with sshd were due to sshd reassigning > > `environ' when setenv() thinks it owns it. setenv() subsequently > > realloc()s the new version of environ and *boom* > > Uhm, Brian ? Could you please remove EXTRA_SANITY in malloc.c again ? *GASP*..... sh*t ! Thanks. > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > phk@FreeBSD.ORG | TCP/IP since RFC 956 > FreeBSD coreteam member | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message