From owner-svn-src-head@FreeBSD.ORG Wed Sep 26 19:23:56 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6B883106564A; Wed, 26 Sep 2012 19:23:56 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 1F9ED8FC08; Wed, 26 Sep 2012 19:23:56 +0000 (UTC) Received: by pbbrp8 with SMTP id rp8so2836961pbb.13 for ; Wed, 26 Sep 2012 12:23:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:in-reply-to:mime-version:content-transfer-encoding :content-type:message-id:cc:x-mailer:from:subject:date:to; bh=JBx9ImHrsUo2ldhptqG6du5pwV4VL0PH8BAkmKAH6us=; b=QWh52ju2eYc961yhoYFCq66deR5DaBMuaSoLF3P50uwW6sATOlo7Y+btNdF8S6e4qZ 5eC6Qdt3ca78rh7ZrSBwGfcTI6FoGsyzQkNXDIREBv5vhein0V2nNpyN8wkAHnsYM0By bO7WGzKoLJegQkgoQycfyFvEwrvvU+3uWkg+o9ghjwBMcf9x/PokWf7ERy34ehPru0Jc L2YaneFhaNIqnxsPjF+P36yW0foT9HtzXVf7XCzkJO8abnTkPdkUO5tdOpc1b8SQVc0H L/knm0ugp/XhzAQ5t6bnR9TsG29FbIWCH4pUN1hfWMrctR2kknUKfJRrHIpgVO42cQtf nv/w== Received: by 10.68.234.36 with SMTP id ub4mr5261505pbc.68.1348687435825; Wed, 26 Sep 2012 12:23:55 -0700 (PDT) Received: from [10.74.194.115] (mobile-166-147-094-118.mycingular.net. [166.147.94.118]) by mx.google.com with ESMTPS id iv7sm2483968pbc.68.2012.09.26.12.23.52 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 26 Sep 2012 12:23:55 -0700 (PDT) References: <201209261804.q8QI4H9P069204@svn.freebsd.org> <20120926184643.GD1309@glenbarber.us> <20120926190451.GA92155@FreeBSD.org> In-Reply-To: <20120926190451.GA92155@FreeBSD.org> Mime-Version: 1.0 (1.0) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Message-Id: X-Mailer: iPhone Mail (9B206) From: Garrett Cooper Date: Wed, 26 Sep 2012 12:23:46 -0700 To: Alexey Dokuchaev Cc: "svn-src-head@freebsd.org" , Glen Barber , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Subject: Re: svn commit: r240967 - head/release X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2012 19:23:56 -0000 On Sep 26, 2012, at 12:04 PM, Alexey Dokuchaev wrote: > On Wed, Sep 26, 2012 at 02:46:43PM -0400, Glen Barber wrote: >> On Wed, Sep 26, 2012 at 11:44:07AM -0700, Garrett Cooper wrote: >>>> -: ${RELSTRING=3D`chroot $2 uname -s`-`chroot $2 uname -r`-`chroot $2 u= name -p`} >>>> +if [ "x${OSVERSION}" =3D=3D "x" ]; then >>>=20 >>> This should be `=3D` in order to be backwards compatible with older >>> (pre-9.1) copies of /bin/sh >>=20 >> This won't be going into pre-9.1 versions of FreeBSD. >=20 > Still, there is no need to spread this bogus syntax which we had erroneous= ly adopted. If you aren't leading the pack, you have to follow the herd (linux). This syntax was added to our copy of ash after some discussion on the posix l= ist re: test(1) syntax. Fighting this inconsistency (bash/zsh syntax) causes more unnecessary turmoi= l and churn in Linux centric projects than needed (and there are a number of= bashisms/zshisms we still don't support). I think it's fine to go with the n= ew syntax as long as things that are FreeBSD specific prefer the old syntax a= s long as 8.2/9.0 and their respective versions are still supported and one c= an upgrade from older versions (this is squishy, but rule of thumb the last I= heard was 2-3 major versions). Thanks! -Garrett=