Date: Wed, 26 Sep 2012 12:23:46 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Glen Barber <gjb@FreeBSD.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r240967 - head/release Message-ID: <EBB80111-DF45-4F68-8E0D-D5F849863C09@gmail.com> In-Reply-To: <20120926190451.GA92155@FreeBSD.org> References: <201209261804.q8QI4H9P069204@svn.freebsd.org> <CAGH67wTNNs1Rt-KS3FYKWCfAY77_0Dhix=9dhuA3nCydqHm_Gw@mail.gmail.com> <20120926184643.GD1309@glenbarber.us> <20120926190451.GA92155@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sep 26, 2012, at 12:04 PM, Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
> On Wed, Sep 26, 2012 at 02:46:43PM -0400, Glen Barber wrote:
>> On Wed, Sep 26, 2012 at 11:44:07AM -0700, Garrett Cooper wrote:
>>>> -: ${RELSTRING=3D`chroot $2 uname -s`-`chroot $2 uname -r`-`chroot $2 u=
name -p`}
>>>> +if [ "x${OSVERSION}" =3D=3D "x" ]; then
>>>=20
>>> This should be `=3D` in order to be backwards compatible with older
>>> (pre-9.1) copies of /bin/sh
>>=20
>> This won't be going into pre-9.1 versions of FreeBSD.
>=20
> Still, there is no need to spread this bogus syntax which we had erroneous=
ly adopted.
If you aren't leading the pack, you have to follow the herd (linux).
This syntax was added to our copy of ash after some discussion on the posix l=
ist re: test(1) syntax.
Fighting this inconsistency (bash/zsh syntax) causes more unnecessary turmoi=
l and churn in Linux centric projects than needed (and there are a number of=
bashisms/zshisms we still don't support). I think it's fine to go with the n=
ew syntax as long as things that are FreeBSD specific prefer the old syntax a=
s long as 8.2/9.0 and their respective versions are still supported and one c=
an upgrade from older versions (this is squishy, but rule of thumb the last I=
heard was 2-3 major versions).
Thanks!
-Garrett=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EBB80111-DF45-4F68-8E0D-D5F849863C09>