From owner-freebsd-current@freebsd.org Mon Jan 1 00:00:08 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 03BB7EAE022 for ; Mon, 1 Jan 2018 00:00:08 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DA91C69BFF for ; Mon, 1 Jan 2018 00:00:07 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: a9e539ad-ee86-11e7-93a5-cd02e7dc7692 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound2.ore.mailhop.org (Halon) with ESMTPSA id a9e539ad-ee86-11e7-93a5-cd02e7dc7692; Sun, 31 Dec 2017 23:59:40 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w01005RJ008961; Sun, 31 Dec 2017 17:00:05 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1514764805.12000.26.camel@freebsd.org> Subject: Re: SVN r327444 breaks current build From: Ian Lepore To: Oleksandr Tymoshenko , Nathan Whitehorn Cc: freebsd-current@freebsd.org Date: Sun, 31 Dec 2017 17:00:05 -0700 In-Reply-To: <20171231235330.GA63368@bluezbox.com> References: <0b8f0e34-7a39-fd59-7f66-b55f1af0e920@protected-networks.net> <20171231222235.GA62313@bluezbox.com> <20171231235330.GA63368@bluezbox.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jan 2018 00:00:08 -0000 On Sun, 2017-12-31 at 15:53 -0800, Oleksandr Tymoshenko wrote: > Nathan Whitehorn (nwhitehorn@freebsd.org) wrote: > > > > > > > > On 12/31/17 14:22, Oleksandr Tymoshenko wrote: > > > > > > Michael Butler (imb@protected-networks.net) wrote: > > > > > > > > Building /usr/obj/usr/src/amd64.amd64/sys/VM01/vt_font_default.o > > > > --- vt_termcolors.o --- > > > > /usr/src/sys/dev/vt/colors/vt_termcolors.c:158:55: error: too many > > > > arguments to function call, expected 4, have 5 > > > >                          if (vt_parse_rgb_triplet(rgb, strlen(rgb), &r, > > > > &g, &b) == 0) { > > > >                              ~~~~~~~~~~~~~~~~~~~~ > > > >    ^~ > > > > /usr/src/sys/dev/vt/colors/vt_termcolors.c:77:1: note: > > > > 'vt_parse_rgb_triplet' declared here > > > > static int > > > > ^ > > > > 1 error generated. > > > > *** [vt_termcolors.o] Error code 1 > > > > > > > > .. second time today a commit wasn't tested before commit :-( > > > > > > > > imb > > > Should be fixed in r327449. It was a sloppy job, I was making iterative > > > improvements to the original patch following review feedback and used > > > out-of-tree testcases for actual testing. I appologize for the breakage. > > > > > Still broken with GCC. > > > > /usr/src/sys/dev/vt/colors/vt_termcolors.c:148: warning: function  > > declaration isn't a prototype [-Wstrict-prototypes] > > *** [vt_termcolors.o] Error code 1 > *sigh* Should be fixed in r327454. Thanks for reporting > > I wonder if we can get clang to be more strict about > declarations/prototypes/etc to match gcc's expectations. I understand > that it's developers' responsibility to make sure that kernel > is GCC-buildable but if raising red flag for some of the cases > when compiling with clang reduced number of these breakages > that it'd be an improvement. > I think we can get clang to do that with -Wstrict-prototypes, but I'm not sure when that option appeared in terms of clang version, and the clang site doesn't seem to provide documentation for anything other than the current in-development version. -- Ian