From owner-svn-src-stable@freebsd.org Wed Apr 11 19:49:36 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 71BF7F8C435; Wed, 11 Apr 2018 19:49:36 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C28366F35C; Wed, 11 Apr 2018 19:49:35 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w3BJnKRC042403 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 11 Apr 2018 22:49:23 +0300 (EEST) (envelope-from kib@freebsd.org) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w3BJnKRC042403 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w3BJnKO5042402; Wed, 11 Apr 2018 22:49:20 +0300 (EEST) (envelope-from kib@freebsd.org) X-Authentication-Warning: tom.home: kostik set sender to kib@freebsd.org using -f Date: Wed, 11 Apr 2018 22:49:20 +0300 From: Konstantin Belousov To: John Baldwin Cc: Slawa Olhovchenkov , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r332091 - stable/11/sys/vm Message-ID: <20180411194920.GM1774@kib.kiev.ua> References: <201804060925.w369P8c2019558@repo.freebsd.org> <20180409162909.GF6612@zxy.spb.ru> <84716725.OOlTe33nR2@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <84716725.OOlTe33nR2@ralph.baldwin.cx> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2018 19:49:36 -0000 On Wed, Apr 11, 2018 at 08:52:08AM -0700, John Baldwin wrote: > On Monday, April 09, 2018 07:29:09 PM Slawa Olhovchenkov wrote: > > On Fri, Apr 06, 2018 at 09:25:08AM +0000, Konstantin Belousov wrote: > > > > > Author: kib > > > Date: Fri Apr 6 09:25:08 2018 > > > New Revision: 332091 > > > URL: https://svnweb.freebsd.org/changeset/base/332091 > > > > > > Log: > > > MFC r331760: > > > Make vm_map_max/min/pmap KBI stable. > > > > > > Modified: > > > stable/11/sys/vm/vm_map.c > > > stable/11/sys/vm/vm_map.h > > > Directory Properties: > > > stable/11/ (props changed) > > > > -STABLE still crashed after load vboxnet build on 11.1-RELEASE > > nvidia (build on 11.1-RELEASE) also don't work > > Yes, this only helps with the future KBI, it doesn't restore the > existing one. However, r320889 which was committed earlier should > have restored the KBI? I am not sure. It might have, but there might be more breakage accumulated. My current opinion is that both vbox and nvidia (as well as in-tree and out of tree drm modules) must be marked as tied. The modules definitely depends on much more kernel interfaces than a typical HBA or network controller driver, for which the stability claim is actually intended to apply.