From owner-cvs-src@FreeBSD.ORG Wed Feb 18 09:41:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9019A16A4CE; Wed, 18 Feb 2004 09:41:04 -0800 (PST) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 64FCA43D1D; Wed, 18 Feb 2004 09:41:04 -0800 (PST) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (localhost [127.0.0.1]) by ns1.xcllnt.net (8.12.10/8.12.10) with ESMTP id i1IHf4OE008010; Wed, 18 Feb 2004 09:41:04 -0800 (PST) (envelope-from marcel@ns1.xcllnt.net) Received: (from marcel@localhost) by ns1.xcllnt.net (8.12.10/8.12.10/Submit) id i1IHex06008009; Wed, 18 Feb 2004 09:40:59 -0800 (PST) (envelope-from marcel) Date: Wed, 18 Feb 2004 09:40:59 -0800 From: Marcel Moolenaar To: John Baldwin Message-ID: <20040218174059.GC7878@ns1.xcllnt.net> References: <200401192127.i0JLRBL3041817@repoman.freebsd.org> <20040218093149.A19121@gamplex.bde.org> <20040218010034.GA64412@ns1.xcllnt.net> <200402180839.09285.jhb@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200402180839.09285.jhb@FreeBSD.org> User-Agent: Mutt/1.5.5.1i cc: src-committers@FreeBSD.org cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Poul-Henning Kamp cc: Jun Kuriyama Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2004 17:41:04 -0000 On Wed, Feb 18, 2004 at 08:39:09AM -0500, John Baldwin wrote: > > Use MPASS() (macros that came in with SMPng from BSD/OS). MPASS(foo) will > work much like assert() in userland including file/line number info. I use > it a lot for simple != NULL tests and the like. I like the behaviour of MPASS(), just not its name and the fact it's defined in lock.h. If we can call it ASSERT and move its definition to systm.h, then I'm hooked. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net