From owner-freebsd-mobile@FreeBSD.ORG Fri Oct 19 15:24:20 2012 Return-Path: Delivered-To: mobile@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 05A3AB18; Fri, 19 Oct 2012 15:24:20 +0000 (UTC) (envelope-from villa.alberto@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 005788FC12; Fri, 19 Oct 2012 15:24:18 +0000 (UTC) Received: by mail-bk0-f54.google.com with SMTP id jf20so293350bkc.13 for ; Fri, 19 Oct 2012 08:24:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=/uDFjawd0zwwGUoX1aNeebeBVsEjt6Ds2nFyALIubLc=; b=hGptjki8NP4ytDtYNQvvaygCZA8MPUMaBwtMVzatZPzyqLxxMc7robXt6Paso0bR3Q yC7a6WmC+0iUwrf7tigtIeGBlQ1abe5sWKyBLKWRDnvByPZO1VTaRMOkHrrHri9buKJN qq2uRP0igtk35T+MuX/ZEkfwdMlniRdTx+UnRuobOWFXzY7twbfBq+88ZNlmzVtpDDdM g0/LYhwk+EVMsKiQYDbvyJ4O1guAppwlTHOZ7TcfexuVuP2X1CNWHpeLTnnPTG5OVkgM pIOZIKh0mWvVD7hzAKe13IQdz8nJiNTye97Gdzydv52sflItNK5w7YIF3y6qPlI1oOJL kXjg== Received: by 10.205.118.136 with SMTP id fq8mr569814bkc.24.1350660257659; Fri, 19 Oct 2012 08:24:17 -0700 (PDT) MIME-Version: 1.0 Sender: villa.alberto@gmail.com Received: by 10.205.81.1 with HTTP; Fri, 19 Oct 2012 08:23:57 -0700 (PDT) In-Reply-To: <201210121006.17276.jhb@freebsd.org> References: <20121005215316.GA38707@triton8.kn-bremen.de> <201210121006.17276.jhb@freebsd.org> From: Alberto Villa Date: Fri, 19 Oct 2012 17:23:57 +0200 X-Google-Sender-Auth: -e10-WbPE1ONQz6s4UALnIwk8fQ Message-ID: Subject: Re: Dell acpi_video patch To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Cc: acpi@freebsd.org, freebsd-acpi@freebsd.org, Juergen Lock , mobile@freebsd.org X-BeenThere: freebsd-mobile@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mobile computing with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2012 15:24:20 -0000 On Fri, Oct 12, 2012 at 4:06 PM, John Baldwin wrote: > I think this is correct, but in we need to do more to properly handle that > flag (DOD_DEVID_SCHEME_STD). Specifically, we shouldn't trust any bits in the > device ID unless that bit is set (except for the special case of > DOD_DEVID_LCD) as per my reading of the _DOD description in the ACPI 3.0b > spec. I think this larger patch will do that while also fixing your case: By the way, it looks like also 0x0100 and 0x0200 should be handled as legacy values: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=include/acpi/video.h;h=61109f2609fc3ee446ec43e242875b28ae719344;hb=HEAD http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drivers/acpi/video.c;h=f94d4c818fc74dc9a076e8f67fe98d7bc6620a61;hb=HEAD -- Alberto Villa, FreeBSD committer http://people.FreeBSD.org/~avilla