From owner-svn-src-stable-7@FreeBSD.ORG Tue Jul 21 13:43:59 2009 Return-Path: Delivered-To: svn-src-stable-7@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2D56910656EF; Tue, 21 Jul 2009 13:43:59 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id E45AE8FC16; Tue, 21 Jul 2009 13:43:58 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 9624446B65; Tue, 21 Jul 2009 09:43:58 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id C2B7F8A09C; Tue, 21 Jul 2009 09:43:56 -0400 (EDT) From: John Baldwin To: obrien@freebsd.org Date: Tue, 21 Jul 2009 09:33:23 -0400 User-Agent: KMail/1.9.7 References: <200907142046.n6EKkJwO070823@svn.freebsd.org> <20090721040810.GA84807@dragon.NUXI.org> In-Reply-To: <20090721040810.GA84807@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200907210933.24176.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Tue, 21 Jul 2009 09:43:57 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-7@freebsd.org Subject: Re: svn commit: r195696 - in stable/7: crypto/openssh secure/lib/libssh X-BeenThere: svn-src-stable-7@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 7-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2009 13:44:03 -0000 On Tuesday 21 July 2009 12:08:10 am David O'Brien wrote: > On Tue, Jul 14, 2009 at 08:46:19PM +0000, John Baldwin wrote: > > Date: Tue Jul 14 20:46:19 2009 > > New Revision: 195696 > > URL: http://svn.freebsd.org/changeset/base/195696 > > Log: > > MFC: Use the closefrom(2) system call. > > Modified: > > stable/7/crypto/openssh/ (props changed) > > stable/7/crypto/openssh/config.h > > stable/7/crypto/openssh/ssh_namespace.h > > stable/7/secure/lib/libssh/ (props changed) > > stable/7/secure/lib/libssh/Makefile > > Hi John, > Would you mind backing out this commit from 7-stable. > This change mades it so one cannot seriously boot a machine multiuser > with an older kernel as /usr/sbin/sshd dies due to bad system call. I > think the MFC of this part of the closefrom(2) addtion edge up against > POLA for a mature -stable branch. > > Even in -CURRENT it's good form to add a new system call and then > immedately use it... without some time laps to allow folks to boot > a week old kernel. Will do, no problem. -- John Baldwin