Date: Mon, 30 Jul 2012 21:35:51 +0200 From: Tijl Coosemans <tijl@coosemans.org> To: Boris Samorodov <bsam@passap.ru> Cc: freebsd-emulation@FreeBSD.org, bug-followup@FreeBSD.org Subject: Re: ports/169702: [patch] graphics/linux-f10-tiff: fix packing list Message-ID: <5016E217.2000602@coosemans.org> In-Reply-To: <5016ADB2.9020205@passap.ru> References: <201207301200.q6UC0aHj014396@freefall.freebsd.org> <50167B84.7040808@passap.ru> <50168F36.9060004@coosemans.org> <5016ADB2.9020205@passap.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On 30-07-2012 17:52, Boris Samorodov wrote:
> 30.07.2012 17:42, Tijl Coosemans пишет:
>> On 30-07-2012 14:18, Boris Samorodov wrote:
>>> 30.07.2012 16:00, Tijl Coosemans пишет:
>>>> On 30-07-2012 13:39, Boris Samorodov wrote:
>>>> > While agree with DESCR part, I'm not sure about PLIST one
>>>> > since I can't reproduce it. Can you provide some more
>>>> > details?
>>>>
>>>> I'll take a closer look later, but maybe it's because I have
>>>> "WRKDIRPREFIX=/usr/obj" in /etc/make.conf.
>>>
>>> That imho should not be the case.
>>
>> It's because of WRKDIRPREFIX in combination with portmaster.
>>
>>>> Also, in bsd.port.mk
>>>> the default value of PLIST is ${PKGDIR}/pkg-plist.
>>>
>>> This is really more accurate. Seems that this should be
>>> done for all ports using a non-standard PLIST.
>>
>> Yes, here are some others:
>>
>> # grep -R '^PLIST=' * | grep -v -E '(WRKDIR|CURDIR|PKGDIR|MASTERDIR|FILESDIR|WRKSRC|NONEXISTENT)'
>> audio/linux-esound/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH}
>> audio/linux-f10-libaudiofile/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH}
>> audio/linux-libaudiofile/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH}
>> cad/salome/Makefile.ext:PLIST= ../salome${PKGNAMESUFFIX}/pkg-plist
>> devel/linux-libglade/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH}
>> devel/linux-libglade2/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH}
>> games/qix/Makefile:PLIST= pkg-plist.x11
>> graphics/linux-f10-imlib/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH}
>> graphics/linux-f10-tiff/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH}
>> graphics/linux-imlib/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH}
>> graphics/linux-tiff/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH}
>> graphics/linux-ungif/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH}
>> japanese/namazu2/Makefile:PLIST= "@comment this plist is intentionally left empty"
>> security/ossec-hids-client/Makefile:PLIST= pkg-plist.client
>> security/sinfp/Makefile:PLIST= ""
>> textproc/linux-libxml/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH}
>> textproc/linux-libxml2/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH}
>> x11-toolkits/linux-f10-gtk/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH}
>> x11-toolkits/linux-f10-qt33/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH}
>> x11-toolkits/linux-gtk/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH}
>> x11-toolkits/linux-qt33/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH}
>>
>
> OK, as of linux ports. Here is a patch. Any objections?
Looks good to me.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5016E217.2000602>