Date: Tue, 7 May 2019 07:45:01 -0300 From: Renato Botelho <garga@FreeBSD.org> To: Dmitry Chagin <dchagin@freebsd.org>, rgrimes@freebsd.org Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r347218 - head/sys/compat/linsysfs Message-ID: <57ea4a23-c78e-1871-e06b-baf4f78882fd@FreeBSD.org> In-Reply-To: <CAC0jpUCgzef1ZAWqGXZTXv6_W19SzHtiKi0PcxiywX==vzHtdg@mail.gmail.com> References: <201905070508.x4758DW5015688@repo.freebsd.org> <201905070531.x475VuIY010069@gndrsh.dnsmgr.net> <CAC0jpUCgzef1ZAWqGXZTXv6_W19SzHtiKi0PcxiywX==vzHtdg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/05/19 02:45, Dmitry Chagin wrote: > вт, 7 мая 2019 г. в 08:32, Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net>: > >>> Author: dchagin >>> Date: Tue May 7 05:08:13 2019 >>> New Revision: 347218 >>> URL: https://svnweb.freebsd.org/changeset/base/347218 >>> >>> Log: >>> Remove wrong copyright line. Discussed with Carlos Neira. >>> >>> Reported by: Rodney W. Grimes >> normally just use a committers username, aka rgrimes or rgrimes@ >> for these types of things. >> >> > ah, I see only: Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net> > > > >>> MFC after: 2 weeks >>> Differential Revision: https://reviews.freebsd.org/D13656 >> >> Hang on, now you removed his copyright? >> I see he said that was ok, but that was not the desired intent here. >> It would of been fine to have the copyright read: >> >> * Copyright (c) 2006 IronPort Systems >> * All rights reserved. >> * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com >> >> As a heads up to other committers you should never insert your >> copyright between another copyright and the "All rights reserved." text, >> if you wish to assert the all rights reserved you should duplicate >> it like: >> >> * Copyright (c) 2006 IronPort Systems >> * All rights reserved. >> * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com >> * All rights reserved. >> >> preferably on the line with your copyright as in: >> * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com All rights >> reserved. >> >> But if at all possible it would be best if we could not add any >> more of these, and remove them when possible. >> >> > and that actually I did. thanks Rod was saying to remove "All rights reserved" when possible, not the Copyright line. -- Renato Botelho
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?57ea4a23-c78e-1871-e06b-baf4f78882fd>